fix: Reference subquery columns instead of outer columns where appropriate #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riate Signed-off-by: Alex Qyoun-ae <[email protected]>
MazterQyou
force-pushed
the
cubesql/fix-subquery-outer-column-ref
branch
from
10875bb to
e11ff0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with column resolving picking up outer columns where it shouldn't. One example when this happened is when
ORDER BYhad an aggregate function over a column that was not aggregated over (e.g.SELECT c1 FROM t GROUP BY c1 ORDER BY SUM(c2)). In such cases the schema would lackc2when resolving order clauses, leading to it picking upc2from outer context instead of adding missing columns/aggregate expressions down the plan.Related test is included but disabled because #203 is a requirement for this test to work; it will be re-enabled when #203 has been merged.