chore: normaliza repository url #927
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,40 +1,30 @@ | ||
| name: Publish | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths-ignore: | ||
| - '.changeset/**' | ||
| - '.husky/**' | ||
| push: | ||
| branches: | ||
| - main | ||
|
|
||
| concurrency: | ||
| group: publish-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
| id-token: write # Required for trusted publishing (OIDC) | ||
|
|
||
| jobs: | ||
| publish-canary: | ||
| name: 'Build & canary release' | ||
| if: github.event_name == 'pull_request' | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| NODE_OPTIONS: --max-old-space-size=4096 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
|
|
@@ -64,6 +54,11 @@ jobs: | |
| - name: Update npm for trusted publishing | ||
| run: npm install -g npm@latest | ||
|
|
||
| - name: Verify npm version and OIDC availability | ||
| run: | | ||
| echo "npm version: $(npm --version)" | ||
| echo "OIDC available: ${{ env.ACTIONS_ID_TOKEN_REQUEST_URL != '' }}" | ||
|
|
||
| - name: Install dependencies | ||
| run: pnpm install | ||
|
|
||
|
|
@@ -81,9 +76,12 @@ jobs: | |
| - name: Build project | ||
| run: pnpm build | ||
|
|
||
| - name: Clear .npmrc auth token (use OIDC instead) | ||
| run: npm config delete //registry.npmjs.org/:_authToken || true | ||
|
|
||
| - name: Publish canary to npm | ||
| working-directory: ./dist | ||
| run: npm publish --access public --tag pr_${{ github.event.number }} --provenance | ||
|
|
||
| - name: Comment PR | ||
| uses: actions/github-script@v6 | ||
|
|
@@ -97,22 +95,17 @@ jobs: | |
| body: 'Deployed canary version [${{ steps.version.outputs.version }}](https://www.npmjs.com/package/@cube-dev/ui-kit/v/${{ steps.version.outputs.version }}).', | ||
| github, | ||
| repo: context.repo, | ||
| prNumber: ${{ github.event.number }} | ||
| }) | ||
|
|
||
| publish-release: | ||
| name: 'Publish release' | ||
| if: github.event_name == 'push' | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| NODE_OPTIONS: --max-old-space-size=4096 | ||
| outputs: | ||
| published: ${{ steps.changesets.outputs.published }} | ||
|
There was a problem hiding this comment. Bug: Missing fallback for
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
|
|
@@ -142,9 +135,17 @@ jobs: | |
| - name: Update npm for trusted publishing | ||
| run: npm install -g npm@latest | ||
|
|
||
| - name: Verify npm version and OIDC availability | ||
| run: | | ||
| echo "npm version: $(npm --version)" | ||
| echo "OIDC available: ${{ env.ACTIONS_ID_TOKEN_REQUEST_URL != '' }}" | ||
|
|
||
| - name: Install Dependencies | ||
| run: pnpm install | ||
|
|
||
| - name: Clear .npmrc auth token (use OIDC instead) | ||
| run: npm config delete //registry.npmjs.org/:_authToken || true | ||
|
|
||
| - name: Create Release Pull Request or Publish to npm | ||
| id: changesets | ||
| uses: changesets/action@v1 | ||
|
|
@@ -155,9 +156,60 @@ jobs: | |
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| # NPM_TOKEN not needed - using trusted publishing (OIDC) | ||
|
|
||
| deploy-chromatic-release: | ||
| name: 'Deploy storybook to Chromatic' | ||
| needs: publish-release | ||
| if: github.event_name == 'push' && needs.publish-release.outputs.published == 'false' | ||
| runs-on: ubuntu-latest | ||
| environment: | ||
| name: Chromatic Production | ||
| url: ${{ steps.publish_chromatic.outputs.url }} | ||
| env: | ||
| NODE_OPTIONS: --max-old-space-size=4096 | ||
| CHROMATIC_RETRIES: 5 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Update Corepack | ||
| run: npm i -g corepack@latest | ||
|
|
||
| - name: Enable Corepack (pre) | ||
| run: corepack enable | ||
|
|
||
| - name: Prepare pnpm (pre) | ||
| run: corepack prepare [email protected] --activate | ||
|
|
||
| - uses: actions/cache@v4 | ||
| name: Download storybook cache | ||
| with: | ||
| path: | | ||
| **/node_modules/.cache | ||
| key: ${{ runner.os }}-storybook-${{ github.run_id }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-storybook | ||
|
|
||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version-file: '.nvmrc' | ||
| cache: 'pnpm' | ||
|
|
||
| - name: Enable Corepack | ||
| run: corepack enable | ||
|
|
||
| - name: Prepare pnpm | ||
| run: corepack prepare [email protected] --activate | ||
|
|
||
| - name: Install dependencies | ||
| run: pnpm install | ||
|
|
||
| - name: Publish to Chromatic | ||
| id: publish_chromatic | ||
| uses: chromaui/action@v11 | ||
| with: | ||
| exitZeroOnChanges: true | ||
| exitOnceUploaded: true | ||
| autoAcceptChanges: true | ||
| onlyChanged: true | ||
| projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: OIDC availability check always evaluates to false
The OIDC verification step uses
${{ env.ACTIONS_ID_TOKEN_REQUEST_URL != '' }}to check OIDC availability, but this will always evaluate tofalse. TheACTIONS_ID_TOKEN_REQUEST_URLis a runtime environment variable injected by GitHub Actions infrastructure, not accessible via the workflow'senvcontext (which only includes variables defined inenv:blocks). To check this variable, shell syntax like$ACTIONS_ID_TOKEN_REQUEST_URLmust be used instead of the expression context. The diagnostic output will always show "OIDC available: false" regardless of actual OIDC availability, providing misleading information during troubleshooting.Additional Locations (1)
.github/workflows/publish.yml#L149-L153