Skip to content

fix(Field): complex tooltips #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tenphi merged 1 commit into from
Jan 5, 2026
Merged

fix(Field): complex tooltips #938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-field-wrapper-tooltip-reactnode.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@cube-dev/ui-kit": patch
---

Fix FieldWrapper tooltip prop to properly support ReactNode values, not just strings. Previously, ReactNode tooltips (like JSX fragments) were incorrectly cast to strings, causing them to fail.
2 changes: 1 addition & 1 deletion src/components/form/FieldWrapper/FieldWrapper.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ SideLabel.args = {
export const SideLabelWithTooltip = Template.bind({});
SideLabelWithTooltip.args = {
labelPosition: 'side',
tooltip: 'Long description',
tooltip: <>Long description</>,
};

export const SideLabelWithMessage = Template.bind({});
Expand Down
5 changes: 3 additions & 2 deletions src/components/form/FieldWrapper/FieldWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { Item } from '../../content/Item';
import { Text } from '../../content/Text';
import { Flex } from '../../layout/Flex';
import { Space } from '../../layout/Space';
import { TooltipProvider } from '../../overlays/Tooltip/TooltipProvider';
import { Label } from '../Label';

import { CubeFieldWrapperProps } from './types';
Expand Down Expand Up @@ -142,7 +141,9 @@ export const FieldWrapper = forwardRef(function FieldWrapper(
<Item
icon={<InfoCircleIcon color="#purple-text" />}
size="inline"
tooltip={tooltip as string}
tooltip={
typeof tooltip === 'string' ? tooltip : { title: tooltip }
}
/>
) : null}

Expand Down
Loading