Skip to content

fix(ListBox): item icon props #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tenphi merged 3 commits into from
Jan 6, 2026
Merged

fix(ListBox): item icon props #940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5fcaf8
fix(ListBox): item icon props
tenphi Jan 6, 2026
251906b
fix(ListBox): deps bug * 2
tenphi Jan 6, 2026
7e0767a
chore: add changeset
tenphi Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/red-ghosts-cry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@cube-dev/ui-kit": patch
---

Fix ListBox icon detection and selection change handler dependencies. Custom icons on ListBox items are now properly detected, and the selection change handler correctly responds to `disableSelectionToggle` prop changes.
6 changes: 3 additions & 3 deletions src/components/fields/ListBox/ListBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,7 @@ export const ListBox = forwardRef(function ListBox<T extends object>(
externalSelectionHandler,
isDisabled,
props.selectionMode,
showSelectAll,
disableSelectionToggle,
]);

// Prepare props for useListState with correct selection props
Expand Down Expand Up @@ -1108,7 +1108,7 @@ function Option({
if (
!isCheckable ||
state.selectionManager.selectionMode !== 'multiple' ||
item.icon
filteredItemProps.icon
) {
return (
filteredItemProps.icon ??
Expand Down Expand Up @@ -1149,7 +1149,7 @@ function Option({
isFocused,
isHovered,
validationState,
item.icon,
filteredItemProps.icon,
]);

// Custom click handler for the entire option
Expand Down
Loading