Skip to content

fix(cubesql): Disable filter pushdown over Filter(CrossJoin) #9474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mcheshkov
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

This should help with rewrites filters on top of complex ungrouped-grouped joins as a subquery joins

This should help with rewrites filters on top of complex ungrouped-grouped joins as a subquery joins
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.52%. Comparing base (e7901a7) to head (8826ccc).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9474       +/-   ##
===========================================
+ Coverage   48.03%   76.52%   +28.49%     
===========================================
  Files         171      400      +229     
  Lines       21449   105004    +83555     
  Branches     3723     3724        +1     
===========================================
+ Hits        10303    80358    +70055     
- Misses      10714    24214    +13500     
  Partials      432      432               
Flag Coverage Δ
cube-backend 48.02% <ø> (-0.02%) ⬇️
cubesql 83.84% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcheshkov mcheshkov marked this pull request as ready for review April 15, 2025 16:25
@mcheshkov mcheshkov requested a review from a team as a code owner April 15, 2025 16:25
@ovr ovr requested a review from MazterQyou April 23, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants