feat(cubesql): Support trivial casts in member pushdown #9480
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
This should allow pushing down expressions like
CAST(dimension AS TEXT) AS alias
intoCubeScan
as regular dimensions.This should allow
__cubeJoinField
joins to see moreCubeScan
sSupporting changes:
Remove unused rule for member pushdown from
AllMembers
All matching happening with
CubeScanMembers
on top of actual members node, and this rule does not expect thatmember_name_to_expr
part of analysis can extract members fromCubeScanMembers(AllMembers)
, so there's no reason to keep this ruleAdd explicit type in
var!
macro, to avoid type confusion.