Cast inputs to Cubed arrays in apply_ufunc
#551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomNicholas
reviewed
Aug 13, 2024
| from cubed.array_api.creation_functions import asarray | ||
|
|
||
| specs = [a.spec for a in args if hasattr(a, "spec")] | ||
| spec = specs[0] if len(specs) > 0 else None |
There was a problem hiding this comment.
Should multiple different specs error? Or specs with different values for the allowed memory and intermediate directory. Otherwise isn't it possible to get some confusing behaviour where it isn't super clear which memory configuration and output directory is being used?
There was a problem hiding this comment.
This actually gets checked later when constructing the plan (all specs have to be the same), but I should add a comment to explain that.
thodson-usgs
pushed a commit
to thodson-usgs/cubed
that referenced
this pull request
Oct 24, 2024
* Cast inputs to Cubed arrays in `apply_ufunc` * Add comment about specs being the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.