-
Notifications
You must be signed in to change notification settings - Fork 17
Add better 4x4x4 definition file #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ock moves and rotations defined
I agree this is better in some ways, but not all. Primarily, at the moment, a .tws file encompasses not only a puzzle definition, but also implicitly a metric (since twsearch has a default move set of all non-rotation moves). I definitely see the utility of having a .tws file that includes all moves, but I'd like to get there in stages. First, I want twsearch to support composition of moves in move definitions (to make the file sizes reasonable). Second, I'd like .tws to include metric definitions that can then be chosen by the user. I'd like cubing.js to generate both of these automatically, so all puzzle-geometry-based puzzles just get a "default" .tws file generated by puzzle geometry, and not anything manually manipulated. At the moment, the existing puzzle definitions are good default definitions, as they provide a reasonable default metric (and for 444 we have both obtm and slice turn versions of the files). So at the moment I'm leaning against integrating this pull request. But I encourage discussion. |
The problem with most of the current definition files is that they don't say what order the pieces are in, which makes them almost useless if you want to actually type in an explicit position and solve it. |
Yes, this is true, and I agree they are less than useful for this purpose.
New files generated by puzzlegeometry in cubing.js mitigate this somewhat
by, for each piece,
indicating which moves affect it, in comments at the top of the file.
For example, in the current cubing.js-generated 444, we see
````
Set EDGES 24 2
# 1 F U 2L
# 2 F 2U R
# 3 2F U R
# 4 F D 2L
````
I have not yet "regenerated" all of the default twsearch files because
there are more changes to come.
There's a reason that the directory name is "samples".
…On Thu, Aug 22, 2024 at 6:41 PM benwh1 ***@***.***> wrote:
The problem with most of the current definition files is that they don't
say what order the pieces are in, which makes them almost useless if you
want to actually type in an explicit position and solve it.
—
Reply to this email directly, view it on GitHub
<#56 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMOLS3T7BSURD2CBDYBQ2LZS2HN3AVCNFSM6AAAAABM7ANCY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBWGAYTQOJZHA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
bc46645
to
4690eef
Compare
a9a6719
to
5f57024
Compare
0e4717d
to
83dca4b
Compare
80e28f3
to
d034656
Compare
8d51e28
to
3b30829
Compare
c1f5bcb
to
e7cd1fa
Compare
b6b8f9a
to
e726135
Compare
3e30b1b
to
34d42d9
Compare
Add better 4x4x4 definition with pieces in a logical order and all block moves and rotations defined