Logging

[paoloambrosio]

We should add logging. It's almost impossible to understand what is going on behind the scenes, thus tracking any misbehavior.

We don't need a full-featured logger like Boost.Log or Google Glog. We need a simple class to track what is going on, if instructed to.

[paoloambrosio]

As explained in GOOS, logging should be handled by notifications.

[barneywilliams]

I think this would work much better if the Ruby and C++ sides run in the same process, since a major problem with the current setup, at least when using with GoogleTest, is that if the C++ side dies, Cucumber crashes, and dumps a Ruby stack trace.

Refer again to issue #50

[paoloambrosio]

I disagree. Logging would still be useful on the C++ side, especially to understand user issues.

[rdammkoehler]

As a note here, I submitted a fix to Cucumber a few months back that should at least get you a clean exit from the Cucumber Execution that indicates that the server side (C++) crashed. It applies to all wire-protocol communications.

See cucumber/common#348

.rich

Richard Dammkoehler
rpd AT noradltd.com
847-946-8286
NOrad Ltd.

On Apr 6, 2013, at 9:28 AM, Greg Williams notifications@github.com wrote:

I think this would work much better if the Ruby and C++ sides run in the same process, since a major problem with the current setup, at least when using with GoogleTest, is that if the C++ side dies, Cucumber crashes, and dumps a Ruby stack trace.

Refer again to issue #50

—
Reply to this email directly or view it on GitHub.

[barneywilliams]

Rich,

Thanks!!! I was looking for that patch... Can we get pull request #348
integrated Paolo? It is a HUGE fix for GTest integration with cucumber-cpp.

Paolo,

Yeah, I don't disagree that a separate logging mechanism would be useful.
Not just for GoogleTest, but in general.

Greg Williams | Embedded Craftsman
Atomic Embedded | http://atomicembedded.com
[Ph] +1 616 264 3734 [Fx] +1 616 776 6015

On Sun, Apr 7, 2013 at 12:29 PM, Rich Dammkoehler
notifications@github.comwrote:

As a note here, I submitted a fix to Cucumber a few months back that
should at least get you a clean exit from the Cucumber Execution that
indicates that the server side (C++) crashed. It applies to all
wire-protocol communications.

See cucumber/common#348

.rich

Richard Dammkoehler
rpd AT noradltd.com
847-946-8286
NOrad Ltd.

On Apr 6, 2013, at 9:28 AM, Greg Williams notifications@github.com
wrote:

I think this would work much better if the Ruby and C++ sides run in the
same process, since a major problem with the current setup, at least when
using with GoogleTest, is that if the C++ side dies, Cucumber crashes, and
dumps a Ruby stack trace.

Refer again to issue #50

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/24#issuecomment-16018098
.

[paoloambrosio]

As I see from the pull request history, it was merged a month ago and should be in cucumber 1.2.2+

[barneywilliams]

Oh, cool! Thanks Paolo! We will check it out...

Greg Williams | Embedded Craftsman
Atomic Embedded | http://atomicembedded.com
[Ph] +1 616 264 3734 [Fx] +1 616 776 6015

On Tue, Apr 9, 2013 at 2:52 PM, Paolo Ambrosio notifications@github.comwrote:

As I see from the pull request history, it was merged a month ago and
should be in cucumber 1.2.2+

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/24#issuecomment-16132494
.

[paoloambrosio]

Reopen if we ever decide to do it.