DO NOT MERGE: Testing symbol exporting on AppVeyor #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nre-ableton
force-pushed
the
nre_master_shared-lib-test
branch
2 times, most recently
from
2c9ef95 to
f212f2d
Compare
On Windows, it is necessary to add the __declspec() attribute around some functions/classes in order to correctly link cucumber-cpp as a shared library. This commit adds the makes it possible for users to easily build cucumber-cpp either as a static or dynamic library by defining either CUKE_ENABLE_SHARED_LIB when configuring with CMake.
nre-ableton
force-pushed
the
nre_master_shared-lib-test
branch
from
a10934d to
f4fd14a
Compare
|
If you need to experiment with the build, you should be able to close this PR and set up your personal Travis and AppVeyor builds on your private repo. |
|
@paoloambrosio Yeah, I was really hoping that I could manage to fix this with just a few pushes, but it was evidently harder than I imagined. Anyways, I'll set up AppVeyor/Travis CI on our fork; that will probably be useful for any future patches we may want to submit upstream anyways. Sorry for the noise! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #147, but is just for testing the AppVeyor build. I've created a separate PR to avoid creating too much noise in #147.