Switch to old travis image and enable Xvfb tests on OSX #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 18, 2017
Switch to old travis linux image to fix issue cucumber#169 Enable Xvfb driven examples execution on OSX Move Xvfb-related logic to functions in bash script
|
I've also added running Xvfb examples on OSX and moved Xvfb -related code to functions. |
|
Fixing an issue we cannot reproduce in local is going to be tough. I am in favour of unblocking the CI build to merge pending PRs. @muggenhor what do you think? |
|
Yes, merging this is probably the best, at least on the short term. I'm only worried that on Travis' side they'll remove the pinned image at some point in the future. But we can worry about that when it happens. |
paoloambrosio
approved these changes
Oct 7, 2017
konserw
changed the title
konserw
added a commit
to konserw/cucumber-cpp
that referenced
this pull request
Oct 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is more like workaround for issue #169 - using old travis image fixes our false fails in CI.