-
Notifications
You must be signed in to change notification settings - Fork 133
Fixing Visual Studio 2013 error: no appropriate default constructor available #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looking at the CI failures, I don't think they have anything to do with my changes. |
Right - we've got PRs for fixing CI already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove semicolons after method definition
Could you please squash it to one commit? Anyway it looks good to me but we are blocked on merging because of CI |
Removing semicolons after method definitions
79fa066
to
44d80fa
Compare
…efault constructor available'
…efault constructor available'
This is group-merge which consist actualy of following fixes: * Remove -werror compiler flag to fix failing build with clang ([cucumber#184](cucumber#184) Kamil Strzempowicz) * Add missing virtual destructor in base class SocketServer used by TCPSocketServer and UnixSocketServer ([cucumber#183](cucumber#183) Matthieu Longo) * Fix breaking changes in API of boost-1.66.0 ([cucumber#180](cucumber#180) Matthieu Longo) * Fix conflicting "using std" declaration with "using boost::thread" ([cucumber#181](cucumber#181) Matthieu Longo) * Fixing Visual Studio 2013 error: no appropriate default constructor available ([cucumber#188](cucumber#188) Antoine Allard)
Hi @aallrd, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
Summary
Code fix to remove a
no appropriate default constructor available compilation
error with Visual Studio 2013.Details
I was getting the below error:
Motivation and Context
This fix is required to remove the solve the above error.
It allows the project to be built with the tests enabled with Visual Studio 2013.
How Has This Been Tested?
The patched project was successfully built with all tests passing on our internal CI with Visual Studio 2013/2017 on Windows and GCC 4.9, 6.3 and 7.3 on Linux.
Types of changes
Checklist: