Use dependencies via target_link_libraries exclusively #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows all dependencies to be resolved in CMake's generation step instead of before that time during script execution. Additionally properties such as transitive dependencies are now handled properly and include directories of dependencies automatically added to the include path. NOTE: This includes a workaround for #190 which was originally discovered when doing this change.
|
FYI: the coverage decrease is because the total line count increased more than the covered line count. Covered lines on master 969/1002 -> covered lines by this PR 991/1025. I.e. the percentage is a misleading metric |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows all dependencies to be resolved in CMake's generation step
instead of before that time during script execution.
Additionally properties such as transitive dependencies are now handled
properly and include directories of dependencies automatically added to
the include path.
NOTE: This includes a workaround for #190 which was
originally discovered when doing this change.
This makes #147 work properly when used fully on our CI setups (AppVeyor + Travis).