Skip to content

Supress waring about deprecated QSignalMapper #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

LukasWoodtli
Copy link
Contributor

Summary

Suppress warnings about using QSignalMapper which is deprecated in Qt5.

Details

Deprecation warnings are disabled in the Qt example project.

Motivation and Context

The example project doesn't build when the warnings are enabled.

How Has This Been Tested?

Travis builds with Qt 5 on macOS.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).

Checklist:

  • It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
  • I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
  • I've added tests for my code.
  • I have verified whether my change requires changes to the documentation
  • My change either requires no documentation change or I've updated the documentation accordingly.
  • My branch has been rebased to master, keeping only relevant commits.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.47% when pulling d4e3247 on LukasWoodtli:QSignalMapperFix into dd424c1 on cucumber:master.

@LukasWoodtli LukasWoodtli mentioned this pull request Dec 17, 2019
9 tasks
@jermus67 jermus67 merged commit 38fa7a5 into cucumber:main Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants