Add native cjson support for lua redis scripts #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsDrike
commented
Jul 20, 2025
Owner
|
Thanks for this addition. It is currently not covered by the tests in test_scripting |
Contributor
Author
|
Tests should be in, LMK if they're fine or if you want something more. I also added support for arrays, solving the issue I had, I just used the same behavior that cjson has for this. |
cunla
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds python-native implementation for handling cjson encode/decode lua calls.
Resolves: #304 (already closed, but only with a workaround solution, whereas this PR adds a much more versatile solution without forcing users to handle dynamic binary blob linking and compilation of the lua-cjson lib).
Most of the relevant things regarding the thought process behind this implementation was mentioned in the 2 issue comments I sent, so I'll just link those here, rather than repeating what I already mentioned: