fix(timeseries): parse TS.MRANGE label filters with IN-list and - correctly #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rectly
Bug: filters like `sensor=(A,C)` returned no results because `value[0]`/`value[-1]` comparisons (ints) against `b"("`/`b")"` never matched, and `"-"` was compared as a str instead of bytes.
Fix: use `value.startswith(b"(")/value.endswith(b")")` for IN-lists, compare `value` to `b"-"`, and normalize split values with `.strip()`.
- Ensure `b"-"` comparisons work for existence checks.
- Correctly detect and parse IN-list values `(A,C)`.
- Normalize tuple values when splitting on commas.
- Restores expected results for queries like `filters=["sensor=(A,C)"]`.
Owner
|
Would you mind adding the test for it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior
When using
TS.MRANGEwith an IN-list filter, e.g.filters=["sensor=(A,C)"], fakeredis always returned no results.This happens because:
value[0]andvalue[-1]return ints, so comparing them tob"("/b")"never matched."-"as astragainst abytesvalue, so existence filters also failed.Expected behavior
TS.MRANGEshould return all series whose label value matches any in the IN-list. For example, with labelssensor=A,sensor=B,sensor=C, the filtersensor=(A,C)should return the series with sensors A and C.Enhancement
This change updates
_filter_expression_checkto:value == b"-").value.startswith(b"(")andvalue.endswith(b")").Why this is useful
The IN-list filter is part of the official RedisTimeSeries filter syntax and is widely used for querying multiple label values at once. Aligning fakeredis with Redis behaviour improves test fidelity and avoids surprises when switching between fakeredis and a real Redis server.