Skip to content

Plumb through options for expireat/pexpire/pexpireat #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cunla merged 1 commit into from
Oct 2, 2025
Merged

Plumb through options for expireat/pexpire/pexpireat #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions fakeredis/commands_mixins/generic_mixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,9 @@ def expire(self, key: CommandItem, seconds: int, *args: bytes) -> int:
res = self._expireat(key, self._db.time + seconds, *args)
return res

@command(name="EXPIREAT", fixed=(Key(), Int))
def expireat(self, key: CommandItem, timestamp: int) -> int:
return self._expireat(key, float(timestamp))
@command(name="EXPIREAT", fixed=(Key(), Int), repeat=(bytes,))
def expireat(self, key: CommandItem, timestamp: int, *args: bytes) -> int:
return self._expireat(key, float(timestamp), *args)

@command(name="KEYS", fixed=(bytes,))
def keys(self, pattern: bytes) -> List[bytes]:
Expand Down Expand Up @@ -148,13 +148,13 @@ def persist(self, key: CommandItem) -> int:
key.expireat = None
return 1

@command(name="PEXPIRE", fixed=(Key(), Int))
def pexpire(self, key: CommandItem, ms: int) -> int:
return self._expireat(key, self._db.time + ms / 1000.0)
@command(name="PEXPIRE", fixed=(Key(), Int), repeat=(bytes,))
def pexpire(self, key: CommandItem, ms: int, *args: bytes) -> int:
return self._expireat(key, self._db.time + ms / 1000.0, *args)

@command(name="PEXPIREAT", fixed=(Key(), Int))
def pexpireat(self, key: CommandItem, ms_timestamp: int) -> int:
return self._expireat(key, ms_timestamp / 1000.0)
@command(name="PEXPIREAT", fixed=(Key(), Int), repeat=(bytes,))
def pexpireat(self, key: CommandItem, ms_timestamp: int, *args: bytes) -> int:
return self._expireat(key, ms_timestamp / 1000.0, *args)

@command(name="PTTL", fixed=(Key(),))
def pttl(self, key: CommandItem) -> int:
Expand Down
8 changes: 8 additions & 0 deletions test/test_mixins/test_generic_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,14 @@ def test_expireat_should_return_false_for_missing_key(r: redis.Redis):
assert r.expireat("missing", int(time() + 1)) is False


@pytest.mark.min_server("7")
def test_expireat_should_not_expire_when_expire_is_set(r: redis.Redis):
r.set("foo", "bar")
assert r.get("foo") == b"bar"
assert r.expireat("foo", int(time() + 100), nx=True) == 1
assert r.expireat("foo", int(time() + 200), nx=True) == 0


def test_del_operator(r: redis.Redis):
r["foo"] = "bar"
del r["foo"]
Expand Down
Loading