Repository navigation
chore(deps): bump undici from 6.29.0 to 6.29.1 - #18
Conversation
Closes GHSA-xjj6-f33q-929c / CVE-2026-109869 (high): undici's fetch() created the internal response stream before rejecting a response with more than five content codings, so a server that closed the connection early surfaced a content-length mismatch on an orphaned stream and terminated the process. undici arrives through @actions/http-client under @actions/core, whose ^6.23.0 range already admits 6.29.1, so package.json is unchanged. dist/ is regenerated because the bundle inlines undici and check-dist compares it against a fresh build. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011ya3soxe5kkfQeEw42FD6u
|
| Topic | Details | |||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| Runtime security fixes | Apply undici security and resilience fixes across fetch response handling, TLS configuration, EventSource parsing limits, and WebSocket write backpressure to protect runtime HTTP and streaming flows.Modified files (1)
Latest Contributors(2)
| |||||||||
| Dependency packaging | Pin undici 6.29.1 and regenerate the distributable bundle artifacts so the published action contains the patched dependency rather than only updating development metadata.Modified files (2)
Latest Contributors(2)
|
|
CI has now answered the one open question in the description: That was the real risk here — the bundle was built in a sandbox on Node 22.22.0 while All 6 checks green: That closes item 1 of "what a human should still check". Item 2 stands and is not something CI can answer: this fix only reaches consumers when a release moves the tag they reference — the action ships It does not auto-merge: runtime scope, ships in the published bundle, and Generated by Claude Code |
Owner: @maxigimenez
Linear: n/a — opened by the scheduled dependency security triage
What and why
undici6.29.0 → 6.29.1 (high; transitive, via@actions/http-clientunder@actions/core).GHSA-xjj6-f33q-929c / CVE-2026-109869, patched in 6.29.1. The advisory's own impact text:
One bump closes five advisories.
npm auditreports 0 vulnerabilities afterwards:Agentdropped function-valued TLS options such ascheckServerIdentityVanta has no finding for this repo at all, so none of these has an SLA clock. It files CVE-2026-109869 against
currents-playwright(alert 417) andplaywright-last-failed(alert 86), both due late November, but nothing here. This came out of the lockfile sweep rather than the worklist — scanner coverage, not a sign the finding is minor.Exposure
Runtime, and it ships. The lockfile stanza is not marked
dev, and the chain starts at a rootdependenciesentry:This is the HTTP client the action uses to call the Currents API, and it is inlined into
dist/index.js, which is what actually runs when a workflow references this action. So the vulnerable parser ships to every consumer of the action until this lands — unlike the siblingide-extensioncase, where undici is dev-only.That said, reachability is narrow: the action talks to the Currents API, not to arbitrary attacker-chosen hosts, so triggering it needs that endpoint (or something impersonating it) to return a malformed response.
The fix
lockfile-upgrade.@actions/http-client's^6.23.0already admits 6.29.1, sopackage.jsonis unchanged.Two files move, and the second is required rather than incidental:
package-lock.json— three lines in one stanza (version,resolved,integrity).dist/index.js+.map— regenerated withnpm run package. The bundle inlines undici, so a lockfile-only change would leave the vulnerable code in what actually executes, andcheck-dist.ymlwould fail the PR for a stale bundle.You can confirm the fix landed in the bundle — the patched form replaces
reject(...)withthis.abort(...):grep -c 'reject(new Error(too many content-encodings'on the newdist/index.js` returns 0.On the lockfile diff being exactly 3 lines
npm update undiciin this sandbox also strips"libc": ["glibc"]/["musl"]from 10 dev-only optional binary stanzas — sandbox npm 10.9.4 writing metadata differently from CI. Those fields are the only discriminator between the gnu and musl variants of the same binary, so losing them lets an Alpine install pick the wrong one. I reverted that and applied the undici stanza by hand, then re-rannpm ciand rebuiltdist/from that clean install, which is why the lockfile diff is 3 lines rather than ~35.Breaking-change check
Single patch bump within major 6. No
patches/directory and nopostinstall, so the patch-package trap does not apply.Verification — run on this branch head
npm ci(from the hand-edited lockfile)node_modules/undicireports 6.29.1npm run all(build→format-check→lint→package→test)npm testgit diff --name-onlypackage-lock.json,dist/index.js,dist/index.js.map— nothing elsenpm auditOn
dist/reproducibility, since CI checks it byte-for-bytecheck-dist.ymlrebuilds with Node 24.x and fails ifgit diff dist/is non-empty. This sandbox only has Node 22.22.0, so I verified the toolchain is deterministic across that gap before trusting the regenerated bundle:Since the committed bundle reproduces exactly here, a bundle generated here should likewise reproduce on CI's Node 24. If
check-distfails anyway, that is the Node-major difference and not the dependency change — the fix is to rerunnpm run packageon Node 24 and commit that.CI coverage
Both relevant workflows trigger on
pull_requestwith nopaths:filter, so this diff runs them rather than silently skipping:test.yml(build-test) — build and the Jest suite.check-dist.yml— rebuildsdist/and compares;paths-ignoreis only**.md, which this diff does not match. This is the one that would have caught a lockfile-only fix.codeql-analysis.yml— runs onpull_requesttomain.Why this is Tier B and does not auto-merge
Three independent reasons, any one of which is enough:
undiciis on the sensitive-package list by name, whatever scope it resolves to.What a human should still check
check-distpasses on CI's Node 24. This is the one thing the sandbox could not fully prove — see the reproducibility note above for what to do if it does not.Generated by Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.