Skip to content

Allow using "this" to refer to current token with empty selection #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pokey opened this issue Oct 20, 2022 · 0 comments · Fixed by #1094
Closed

Allow using "this" to refer to current token with empty selection #1043

pokey opened this issue Oct 20, 2022 · 0 comments · Fixed by #1094
Assignees
Labels
enhancement New feature or request

Comments

@pokey
Copy link
Member

pokey commented Oct 20, 2022

Use cases

"take this" / "chuck this" / "bring this to bat" with cursor at end of token. Note that we don't want to auto-expand for implicit destination for a bring command

Approach

After final modifier stages, but right before running action, run containing token stage if target is empty, weak, and has implicit range

Note that we're rely on the fact that implicit (ie unspoken) target for "bring" automatically has an explicit range to avoid expanding when you say eg "bring air" with an empty cursor

@pokey pokey added the enhancement New feature or request label Oct 20, 2022
@AndreasArvidsson AndreasArvidsson self-assigned this Oct 26, 2022
AndreasArvidsson added a commit that referenced this issue Dec 22, 2022
)

- Fixes #1043
- Fixes #1141 
- Depends on #1187

## Checklist

- [x] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)

Co-authored-by: Pokey Rule <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
cursorless-bot pushed a commit that referenced this issue Dec 22, 2022
)

- Fixes #1043
- Fixes #1141 
- Depends on #1187

## Checklist

- [x] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)

Co-authored-by: Pokey Rule <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
pokey added a commit that referenced this issue Dec 23, 2022
)

- Fixes #1043
- Fixes #1141 
- Depends on #1187

## Checklist

- [x] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)

Co-authored-by: Pokey Rule <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
thetomcraig-aya pushed a commit to thetomcraig/cursorless that referenced this issue Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants