Skip to content

Properly determine markdown item insertion delimiter #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks
pokey opened this issue Nov 1, 2022 · 0 comments · Fixed by #1568
Closed
3 tasks

Properly determine markdown item insertion delimiter #1107

pokey opened this issue Nov 1, 2022 · 0 comments · Fixed by #1568
Assignees
Labels
bug Something isn't working lang-markdown Support for the Markdown family of markup languages

Comments

@pokey
Copy link
Member

pokey commented Nov 1, 2022

Should inspect the leading item marker to see if they're using - , * , etc to delimit their lists. Don't forget the newline

These seem to behave a bit like indentation. The item content should actually go between the leading delimiter and the newline, just like with indentation. So I don't think we can just treat it like a simple insertion delimiter. We probably should try to find a way to reuse the pieces of editNew that we use for line targets, rather than simple delimiter insertion

A few tests we'll want:

  • "bring item air before bat"
  • "bring item air after bat"
  • "drink item air"
@pokey pokey added the bug Something isn't working label Nov 1, 2022
@phillco phillco added the lang-markdown Support for the Markdown family of markup languages label Dec 21, 2022
@AndreasArvidsson AndreasArvidsson self-assigned this Jul 3, 2023
github-merge-queue bot pushed a commit that referenced this issue Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lang-markdown Support for the Markdown family of markup languages
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants