You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As of #1143, the TextEditor type now has many functions. We'd like to revisit this api, with the following questions:
Which of these functions belong on the TextEditor?
Should we move them to the top-level ide type, or split them into components?
We should enforce that no range is passed in as an argument if the capabilities don't allow them, rather than just relying on SimpleIdeCommandAction to do the right thing. Ideally would do this with type narrowing; barring that could at least add some checks in the VSCode and forthcoming lsp implementations
Do we want to enforce that some of these functions accept a single range, as we do today?
Do we want some of these methods to support multiple editors?
The text was updated successfully, but these errors were encountered:
As of #1143, the
TextEditor
type now has many functions. We'd like to revisit this api, with the following questions:TextEditor
?ide
type, or split them into components?range
is passed in as an argument if the capabilities don't allow them, rather than just relying onSimpleIdeCommandAction
to do the right thing. Ideally would do this with type narrowing; barring that could at least add some checks in the VSCode and forthcoming lsp implementationsThe text was updated successfully, but these errors were encountered: