Skip to content

Rework TextEditor api #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pokey opened this issue Dec 4, 2022 · 0 comments
Open

Rework TextEditor api #1160

pokey opened this issue Dec 4, 2022 · 0 comments
Labels
code quality Improvements to code quality

Comments

@pokey
Copy link
Member

pokey commented Dec 4, 2022

As of #1143, the TextEditor type now has many functions. We'd like to revisit this api, with the following questions:

  • Which of these functions belong on the TextEditor?
  • Should we move them to the top-level ide type, or split them into components?
  • We should enforce that no range is passed in as an argument if the capabilities don't allow them, rather than just relying on SimpleIdeCommandAction to do the right thing. Ideally would do this with type narrowing; barring that could at least add some checks in the VSCode and forthcoming lsp implementations
  • Do we want to enforce that some of these functions accept a single range, as we do today?
  • Do we want some of these methods to support multiple editors?
@pokey pokey added code quality Improvements to code quality to discuss Plan to discuss at meet-up labels Dec 4, 2022
@pokey pokey removed the to discuss Plan to discuss at meet-up label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improvements to code quality
Projects
None yet
Development

No branches or pull requests

1 participant