Skip to content

"bring item" broken for indented lists #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pokey opened this issue Dec 21, 2022 · 0 comments · Fixed by #1568
Closed

"bring item" broken for indented lists #1200

pokey opened this issue Dec 21, 2022 · 0 comments · Fixed by #1568
Assignees
@AndreasArvidsson
Labels
bug Something isn't working lang-markdown Support for the Markdown family of markup languages

Comments

@pokey
Copy link
Member

pokey commented Dec 21, 2022

In the following markdown:

- aaa
  - bbb
  - ccc
  - ddd
  - eee

Saying "bring item each after bat" results in the following:

- aaa
  - bbb
  - ccc
    eee
  - ddd
  - eee

It seems like this bug is in part because the leading indentation of ccc is included in item - bbb (#1199), but in addition, it seems that the range is being extended to the end of the line.
@pokey pokey added the bug Something isn't working label Dec 21, 2022
@phillco phillco added the lang-markdown Support for the Markdown family of markup languages label Dec 21, 2022
@pokey pokey changed the title [markdown] "bring item" broken for indented lists "bring item" broken for indented lists Dec 24, 2022
@AndreasArvidsson AndreasArvidsson self-assigned this Jul 3, 2023
@AndreasArvidsson AndreasArvidsson mentioned this issue Jul 3, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Jul 7, 2023
@AndreasArvidsson @pokey
Updated markdown item ranges (#1568)
15d7254 
Fixes #1200
Fixes #1199
Fixes #1107

## Checklist

- [x] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [ ] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [ ] I have not broken the cheatsheet

---------

Co-authored-by: Pokey Rule <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreasArvidsson AndreasArvidsson

Labels
bug Something isn't working lang-markdown Support for the Markdown family of markup languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated markdown item ranges cursorless-dev/cursorless
3 participants
@phillco @pokey @AndreasArvidsson