-
-
Notifications
You must be signed in to change notification settings - Fork 84
Don't show warning for "past end of"
#1351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@pokey I was just about to implement this one, but I can't do the second task so it's probably better if you take ownership? Or do you want me to go ahead and do the first task and then hand it over to you? This is where in the code the warning is defined Lines 122 to 151 in 0e4c9d9
|
I don't feel strongly either way. I think either is fine |
- Fixes #1630 - Partially #1351 ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: Pokey Rule <[email protected]>
@pokey The warning is now removed and I have assigned it to us you can update your videos. |
This behaviour could actually be useful in rare cases.
The text was updated successfully, but these errors were encountered: