You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Decorated symbols are supposed to be editor-specific, but as of #1671, we handle spoken form generation in cursorless engine, which is supposed to be editor-agnostic. In particular, these two aspects are problematic:
We should probably inject spoken form generator for this specific piece from the ide. Either that, or force the set of colors / shapes / symbols to be a subset of what we support in VSCode today and then keep doing evertying in engine. In that case, we'd want to switch to strong types everywhere for these
Decorated symbols are supposed to be editor-specific, but as of #1671, we handle spoken form generation in cursorless engine, which is supposed to be editor-agnostic. In particular, these two aspects are problematic:
cursorless/packages/cursorless-engine/src/generateSpokenForm/primitiveTargetToSpokenForm.ts
Lines 220 to 231 in 442f97d
We should probably inject spoken form generator for this specific piece from the ide. Either that, or force the set of colors / shapes / symbols to be a subset of what we support in VSCode today and then keep doing evertying in engine. In that case, we'd want to switch to strong types everywhere for these
See also #946
The text was updated successfully, but these errors were encountered: