Skip to content

Revisit spoken form generation for decorated symbol mark #1709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pokey opened this issue Jul 31, 2023 · 0 comments
Open

Revisit spoken form generation for decorated symbol mark #1709

pokey opened this issue Jul 31, 2023 · 0 comments

Comments

@pokey
Copy link
Member

pokey commented Jul 31, 2023

Decorated symbols are supposed to be editor-specific, but as of #1671, we handle spoken form generation in cursorless engine, which is supposed to be editor-agnostic. In particular, these two aspects are problematic:

We should probably inject spoken form generator for this specific piece from the ide. Either that, or force the set of colors / shapes / symbols to be a subset of what we support in VSCode today and then keep doing evertying in engine. In that case, we'd want to switch to strong types everywhere for these

See also #946

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant