Added generation of spoken form #1671

AndreasArvidsson · 2023-07-22T09:05:05Z

Checklist

Use spoken form generation when recording tests. Update message with the generated spoken form.
I have added tests
[/] I have updated the docs and cheatsheet
[/] I have not broken the cheatsheet
Add tests for list targets with 0 and 1 element, ensuring there's no spoken form
Add tests for list destination with 0 and 1 element, ensuring there's no spoken form

pokey

partial review

packages/common/src/spokenForms/actions.ts

packages/common/src/spokenForms/characters.ts

packages/common/src/spokenForms/marks.ts

packages/common/src/spokenForms/modifiers.ts

packages/common/src/spokenForms/marks.ts

packages/common/src/spokenForms/modifiers.ts

packages/common/src/types/command/PartialTargetDescriptor.types.ts

packages/cursorless-engine/src/core/commandVersionUpgrades/upgradeV1ToV2/upgradeV1ToV2.ts

packages/cursorless-engine/src/core/commandVersionUpgrades/upgradeV2ToV3/upgradeV2ToV3.ts

packages/cursorless-engine/src/core/commandVersionUpgrades/upgradeV4ToV5/upgradeV4ToV5.ts

packages/cursorless-engine/src/core/commandVersionUpgrades/canonicalizeSpokenFormTestCommand.ts

packages/cursorless-engine/src/test/generateSpokenForm.test.ts

AndreasArvidsson · 2023-07-25T17:52:48Z

@pokey Updated wit requested changes from our meetup

pokey · 2023-07-26T18:06:08Z

@AndreasArvidsson did we want to use the spoken form generator for recording test cases in this PR? Tbh, I think I'd almost prefer if update fixtures launch config updated spoken forms. Makes me a bit less nervous than just automatically generating new test cases for the spoken form generator that are based on its behaviour at that moment and requiring us to carefully review them.

But I'd lean towards having one or the other in this PR, as otherwise it's going to be pretty inconvenient the next time someone records a test

packages/common/src/spokenForms/actions.ts

packages/common/src/spokenForms/marks.ts

packages/common/src/spokenForms/modifiers.ts

packages/common/src/types/command/hatStyles.types.ts

packages/cursorless-engine/src/test/generateSpokenForm.test.ts

packages/cursorless-engine/src/core/commandVersionUpgrades/generateSpokenForm.ts

packages/cursorless-engine/src/generateSpokenForm/defaultSpokenForms/characters.ts

packages/cursorless-engine/src/generateSpokenForm/defaultSpokenForms/actions.ts

pokey · 2023-07-31T16:10:20Z

packages/cursorless-engine/src/generateSpokenForm/generateSpokenForm.ts

+      if (destination.destinations.length < 2) {
+        throw new NoSpokenFormError("List destination with < 2 elements");
+      }


No way to speak this one

Same here. I would argue that this should be a normal error.

packages/cursorless-engine/src/generateSpokenForm/generateSpokenForm.test.ts

packages/cursorless-engine/src/generateSpokenForm/NoSpokenFormError.ts

pokey

I'm happy, but @AndreasArvidsson have a look through my comments to make sure you're happy with my changes

pokey · 2023-08-01T11:48:59Z

aggh looks like it's time to fix that E2BIG thing. wrote up a fix; going to test that it works here then cherry pick it to new PR

AndreasArvidsson requested a review from pokey as a code owner July 22, 2023 09:05

AndreasArvidsson mentioned this pull request Jul 22, 2023

Talon side spoken form tests #1637

Merged

11 tasks

pokey reviewed Jul 25, 2023

View reviewed changes

packages/common/src/spokenForms/marks.ts Outdated Show resolved Hide resolved

pokey reviewed Jul 25, 2023

View reviewed changes

packages/cursorless-engine/src/test/generateSpokenForm.test.ts Outdated Show resolved Hide resolved

pokey reviewed Jul 26, 2023

View reviewed changes

packages/common/src/spokenForms/actions.ts Outdated Show resolved Hide resolved