Skip to content

Talon side spoken form tests #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Aug 2, 2023
Merged

Talon side spoken form tests #1637

merged 28 commits into from
Aug 2, 2023

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Jul 16, 2023 •
edited
Loading

Potential manual tests to add

For these, just bake payload and spoken form into consts in the test itself

  • "slice past"
  • "two tokens forward"
  • "one token"
  • "take inside pair"

Checklist

  • Handle if Talon was in sleep mode initially
  • Add deprecation warning if user says "to after"? I believe we support this today, and some users are still saying that, as indicated by slack questions from the past month. We could probably have this as an alternate spoken form for "after" and show a warning if they use it
  • Stop using generateSpokenForms to check whether to run a test; instead read spokenFormError field on recorded test
  • How do we actually want to launch this? Launch config in vscode and then?
  • Add notifications when test start and stop
  • I have added tests
  • [/] I have updated the cheatsheet
  • [/] I have updated the docs
  • I have not broken the cheatsheet

@AndreasArvidsson AndreasArvidsson added the to discuss Plan to discuss at meet-up label Jul 17, 2023
pokey
pokey reviewed Jul 17, 2023
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a couple very quick comments

@AndreasArvidsson AndreasArvidsson removed the to discuss Plan to discuss at meet-up label Jul 19, 2023
@AndreasArvidsson AndreasArvidsson marked this pull request as ready for review July 21, 2023 16:56
@AndreasArvidsson AndreasArvidsson changed the base branch from main to generateSpokenForms July 22, 2023 09:06
@AndreasArvidsson AndreasArvidsson changed the title Talon side spoken form tests Talon side spoken form tests and v6 API Jul 30, 2023
@AndreasArvidsson AndreasArvidsson mentioned this pull request Jul 30, 2023
Closed
8 tasks
This was linked to issues Jul 30, 2023
Rework Talon side to use destinations #1440
Closed
Use data classes on talon side in order to get better type hints #725
Closed
Destinations as first-class objects #803
Closed
Change "take vest past after air" test to "take vest past end of air" #1675
Closed
@AndreasArvidsson AndreasArvidsson added the to discuss Plan to discuss at meet-up label Jul 31, 2023
@pokey pokey force-pushed the generateSpokenForms branch 7 times, most recently from f0092fa to ef56dae Compare July 31, 2023 16:12
@pokey pokey marked this pull request as draft July 31, 2023 16:42
This was unlinked from issues Jul 31, 2023
Destinations as first-class objects #803
Closed
Rework Talon side to use destinations #1440
Closed
@pokey
Copy link
Member

pokey commented Jul 31, 2023

Worth running through the checkboxes in these two issues to see if you've addressed everything. If not, I'm not saying you should do it in this PR, but we should prob not close those issues:

@pokey
Copy link
Member

pokey commented Jul 31, 2023

Also you'll want to make a new branch pointing to what the base should be for this PR; I did a hard reset on the generateSpokenForms branch to make it easier to do some surgery. Then when that's merged you can cherry pick this stuff

This was linked to issues Aug 1, 2023
Destinations as first-class objects #803
Closed
Rework Talon side to use destinations #1440
Closed
Fix 'paste' documentation #1319
Closed
@AndreasArvidsson AndreasArvidsson removed a link to an issue Aug 1, 2023
Rework Talon side to use destinations #1440
Closed
6 tasks
pokey
pokey reviewed Aug 2, 2023
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok this looks good to me, but for some reason is still failing for me locally, so we'll need to debug. Also worth having a look at the changes I made

@AndreasArvidsson
Copy link
Member Author

Ok this looks good to me, but for some reason is still failing for me locally, so we'll need to debug. Also worth having a look at the changes I made

The changes just looks fine. I just discover that after Talon has restarted some of the tests are failing for me as well. Touching a single Talon user file fixes this for some reason.

@pokey
Copy link
Member

pokey commented Aug 2, 2023

oh haha you're right!

@AndreasArvidsson
Copy link
Member Author

Its the Cursorless simple actions list that don't get updated to default unless you touch a file. I will investigate further

@pokey pokey enabled auto-merge August 2, 2023 17:40
@pokey pokey added this pull request to the merge queue Aug 2, 2023
Merged via the queue into main with commit 6831391 Aug 2, 2023
@pokey pokey deleted the grammar_test branch August 2, 2023 18:01
cursorless-bot pushed a commit that referenced this pull request Aug 2, 2023
@AndreasArvidsson @pokey @pre-commit-ci-lite
Talon side spoken form tests (#1637)
1a62f3c 
- Fixes #449
- Fixes #1675

## Potential manual tests to add

For these, just bake payload and spoken form into `const`s in the test
itself

- [x] "slice past"
- [x] "two tokens forward"
- [x] "one token"
- [x] "take inside pair"

## Checklist

- [x] Handle if Talon was in sleep mode initially
- [x] Add deprecation warning if user says "to after"? I believe we
support this today, and some users are still saying that, as indicated
by slack questions from the past month. We could probably have this as
an alternate spoken form for "after" and show a warning if they use it
- [x] Stop using `generateSpokenForms` to check whether to run a test;
instead read `spokenFormError` field on recorded test
- [x] How do we actually want to launch this? Launch config in vscode
and then?
- [x] Add notifications when test start and stop
- [x] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [/] I have updated the
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [/] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs)
- [x] I have not broken the cheatsheet

---------

Co-authored-by: Pokey Rule <[email protected]>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Aug 6, 2023
@AndreasArvidsson @pokey @pre-commit-ci-lite
Added destination and v6 api to Talon (#1717)
41e0c26 
Depends on #1637

- Fixes #725
- Partially addresses #1440
- Fixes #1319 

## Checklist

- [/] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] Update cheatsheet spoken form defaults
- [x] Manually test the various snippet terms
- [x] Manually test the snippet apis
- [ ] I have not broken the cheatsheet

---------

Co-authored-by: Pokey Rule <[email protected]>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
cursorless-bot pushed a commit to cursorless-dev/cursorless-talon that referenced this pull request Aug 6, 2023
@AndreasArvidsson @pokey
@pre-commit-ci-lite @cursorless-bot
Added destination and v6 api to Talon (#1717)
e37db67 
Depends on cursorless-dev/cursorless#1637

- Fixes #725
- Partially addresses #1440
- Fixes #1319 

## Checklist

- [/] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] Update cheatsheet spoken form defaults
- [x] Manually test the various snippet terms
- [x] Manually test the snippet apis
- [ ] I have not broken the cheatsheet

---------

Co-authored-by: Pokey Rule <[email protected]>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
cursorless-bot pushed a commit that referenced this pull request Aug 6, 2023
@AndreasArvidsson @pokey @pre-commit-ci-lite
Added destination and v6 api to Talon (#1717)
3c9f3f6 
Depends on #1637

- Fixes #725
- Partially addresses #1440
- Fixes #1319 

## Checklist

- [/] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] Update cheatsheet spoken form defaults
- [x] Manually test the various snippet terms
- [x] Manually test the snippet apis
- [ ] I have not broken the cheatsheet

---------

Co-authored-by: Pokey Rule <[email protected]>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
@pokey pokey mentioned this pull request Jan 19, 2024
Closed
3 tasks
thetomcraig-aya pushed a commit to thetomcraig/cursorless that referenced this pull request Mar 27, 2024
@AndreasArvidsson @pokey
@pre-commit-ci-lite @cursorless-bot
Talon side spoken form tests (cursorless-dev#1637)
a60f6a9 
- Fixes cursorless-dev#449
- Fixes cursorless-dev#1675

## Potential manual tests to add

For these, just bake payload and spoken form into `const`s in the test
itself

- [x] "slice past"
- [x] "two tokens forward"
- [x] "one token"
- [x] "take inside pair"

## Checklist

- [x] Handle if Talon was in sleep mode initially
- [x] Add deprecation warning if user says "to after"? I believe we
support this today, and some users are still saying that, as indicated
by slack questions from the past month. We could probably have this as
an alternate spoken form for "after" and show a warning if they use it
- [x] Stop using `generateSpokenForms` to check whether to run a test;
instead read `spokenFormError` field on recorded test
- [x] How do we actually want to launch this? Launch config in vscode
and then?
- [x] Add notifications when test start and stop
- [x] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [/] I have updated the
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [/] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs)
- [x] I have not broken the cheatsheet

---------

Co-authored-by: Pokey Rule <[email protected]>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokey pokey pokey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@AndreasArvidsson @pokey