Skip to content

Use data classes on talon side in order to get better type hints #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pokey opened this issue Jun 2, 2022 · 2 comments · Fixed by #1717
Closed

Use data classes on talon side in order to get better type hints #725

pokey opened this issue Jun 2, 2022 · 2 comments · Fixed by #1717
Assignees
@auscompgeek @AndreasArvidsson
Labels
code quality Improvements to code quality talon Related to cursorless-talon

Comments

@pokey
Copy link
Member

pokey commented Jun 2, 2022

No description provided.

@pokey pokey added the code quality Improvements to code quality label Jun 2, 2022
@auscompgeek
Copy link
Member

I'll probably pick this up this weekend, assuming the massive refactor PR gets merged by then.

@pokey
Copy link
Member Author

pokey commented Jun 2, 2022

cool! we'll ping when it's merged

@pokey pokey mentioned this issue Jul 4, 2022
Merged
1 task
@auscompgeek auscompgeek mentioned this issue Aug 21, 2022
Merged
1 task
@auscompgeek auscompgeek added the talon Related to cursorless-talon label Jul 15, 2023
@AndreasArvidsson AndreasArvidsson mentioned this issue Jul 15, 2023
Closed
8 tasks
@AndreasArvidsson AndreasArvidsson mentioned this issue Jul 30, 2023
Merged
11 tasks
@AndreasArvidsson AndreasArvidsson linked a pull request Jul 30, 2023 that will close this issue
Talon side spoken form tests #1637
Merged
11 tasks
@AndreasArvidsson AndreasArvidsson mentioned this issue Aug 1, 2023
Merged
5 tasks
@AndreasArvidsson AndreasArvidsson removed a link to a pull request Aug 1, 2023
Talon side spoken form tests #1637
Merged
11 tasks
github-merge-queue bot pushed a commit that referenced this issue Aug 6, 2023
@AndreasArvidsson @pokey @pre-commit-ci-lite
Added destination and v6 api to Talon (#1717)
41e0c26 
Depends on #1637

- Fixes #725
- Partially addresses #1440
- Fixes #1319 

## Checklist

- [/] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] Update cheatsheet spoken form defaults
- [x] Manually test the various snippet terms
- [x] Manually test the snippet apis
- [ ] I have not broken the cheatsheet

---------

Co-authored-by: Pokey Rule <[email protected]>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
cursorless-bot pushed a commit that referenced this issue Aug 6, 2023
@AndreasArvidsson @pokey @pre-commit-ci-lite
Added destination and v6 api to Talon (#1717)
3c9f3f6 
Depends on #1637

- Fixes #725
- Partially addresses #1440
- Fixes #1319 

## Checklist

- [/] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] Update cheatsheet spoken form defaults
- [x] Manually test the various snippet terms
- [x] Manually test the snippet apis
- [ ] I have not broken the cheatsheet

---------

Co-authored-by: Pokey Rule <[email protected]>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
@auscompgeek auscompgeek mentioned this issue Sep 5, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Sep 15, 2023
@auscompgeek
Tighten Talon marks type hints (#1848)
adb0918 
This removes a bunch of `Any`s from the Talon code related to marks.

Ref: #725

## Checklist

- [ ] ~I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)~
- [ ] ~I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)~
- [x] I have not broken the cheatsheet
cursorless-bot pushed a commit that referenced this issue Sep 15, 2023
@auscompgeek
Tighten Talon marks type hints (#1848)
47c82e5 
This removes a bunch of `Any`s from the Talon code related to marks.

Ref: #725

## Checklist

- [ ] ~I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)~
- [ ] ~I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)~
- [x] I have not broken the cheatsheet
thetomcraig-aya pushed a commit to thetomcraig/cursorless that referenced this issue Mar 27, 2024
@AndreasArvidsson @pokey
@pre-commit-ci-lite @cursorless-bot
Added destination and v6 api to Talon (cursorless-dev#1717)
e37db67 
Depends on cursorless-dev#1637

- Fixes cursorless-dev#725
- Partially addresses cursorless-dev#1440
- Fixes cursorless-dev#1319 

## Checklist

- [/] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] Update cheatsheet spoken form defaults
- [x] Manually test the various snippet terms
- [x] Manually test the snippet apis
- [ ] I have not broken the cheatsheet

---------

Co-authored-by: Pokey Rule <[email protected]>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
thetomcraig-aya pushed a commit to thetomcraig/cursorless that referenced this issue Mar 27, 2024
@auscompgeek @cursorless-bot
Tighten Talon marks type hints (cursorless-dev#1848)
531417f 
This removes a bunch of `Any`s from the Talon code related to marks.

Ref: cursorless-dev#725

## Checklist

- [ ] ~I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)~
- [ ] ~I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)~
- [x] I have not broken the cheatsheet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@auscompgeek auscompgeek

@AndreasArvidsson AndreasArvidsson

Labels
code quality Improvements to code quality talon Related to cursorless-talon
Projects
None yet
Milestone
No milestone
3 participants
@auscompgeek @pokey @AndreasArvidsson