-
-
Notifications
You must be signed in to change notification settings - Fork 84
Rework Talon side to use destinations #1440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
documentation
Improvements or additions to documentation
Milestone
Comments
This was referenced Jul 11, 2023
8 tasks
11 tasks
11 tasks
11 tasks
11 tasks
11 tasks
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 6, 2023
Depends on #1637 - Fixes #725 - Partially addresses #1440 - Fixes #1319 ## Checklist - [/] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] Update cheatsheet spoken form defaults - [x] Manually test the various snippet terms - [x] Manually test the snippet apis - [ ] I have not broken the cheatsheet --------- Co-authored-by: Pokey Rule <[email protected]> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
cursorless-bot
pushed a commit
that referenced
this issue
Aug 6, 2023
Depends on #1637 - Fixes #725 - Partially addresses #1440 - Fixes #1319 ## Checklist - [/] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] Update cheatsheet spoken form defaults - [x] Manually test the various snippet terms - [x] Manually test the snippet apis - [ ] I have not broken the cheatsheet --------- Co-authored-by: Pokey Rule <[email protected]> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
thetomcraig-aya
pushed a commit
to thetomcraig/cursorless
that referenced
this issue
Mar 27, 2024
Depends on cursorless-dev#1637 - Fixes cursorless-dev#725 - Partially addresses cursorless-dev#1440 - Fixes cursorless-dev#1319 ## Checklist - [/] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] Update cheatsheet spoken form defaults - [x] Manually test the various snippet terms - [x] Manually test the snippet apis - [ ] I have not broken the cheatsheet --------- Co-authored-by: Pokey Rule <[email protected]> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Talon side
On the Talon side, we would like to do the following:
1. Make
"before"
,"after"
and"to"
into "insertion modes"We'll have a new list called
cursorless_insertion_mode
, which will consist of"before"
,"after"
and"to"
.These terms should also be removed from both
cursorless_position
andcursorless_source_destination_connective
.Note that
"end of"
and"start of"
remain as position modifiers.2. Add new capture for destinations
Replace the
<cursorless_positional_target>
capture with the following:Note that we are using the
cursorless_target
capture as part of this capture, which can contain its own"and"
s. That's how we support"after air and bat and before cap"
.We would then use this new
cursorless_destination
capture wherever we usecursorless_positional_target
today.Note that we might instead want to do something like we do with targets, where the primitive destination can appear at the top level when there is no "and"
Problems
"before"
and"after"
inpositions.csv
, and"to"
inconnectives.csv
, but ideally we'd move them into the same file as each otherThe text was updated successfully, but these errors were encountered: