Fix type hints #822
Merged
Fix type hints #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auscompgeek
approved these changes
Jul 4, 2022
| await_command: bool = True | ||
|
|
||
|
|
||
| def get_parameters(action: MakeshiftAction): | ||
| command = action.vscode_command_id | ||
| command_options = { | ||
| command_options: dict[str, Any] = { |
There was a problem hiding this comment.
No; see a few lines below: we can have vscode_command_args at key "commandArgs". This will be a list of items of unknown type, as they are arguments to an arbitrary VSCode command
There was a problem hiding this comment.
Ah. I'll see if I can't turn this into a dataclass or something at some point then.
There was a problem hiding this comment.
Ah right yeah that sounds good. You mean as part of #725 I assume
cursorless-bot
pushed a commit
that referenced
this pull request
Jul 4, 2022
thetomcraig-aya
pushed a commit
to thetomcraig/cursorless
that referenced
this pull request
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed all the easy ones. There were a few that I couldn't fix due to the way Talon works, eg not having
selfarg in action classesChecklist