Fix slow DFA compilation #2187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

2 of 3 tasks

pokey opened this issue Jan 19, 2024 · 3 comments

Assignees

Milestone

Member

pokey commented Jan 19, 2024 •

edited

Loading

Cursorless DFA compilation has slowed down in the past year. Here are the two major culprits:

We should figure out how to mitigate these slowdowns

To try for #1637:

Comment out https://github.com/cursorless-dev/cursorless/pull/1637/files#diff-9cbdeabb002e18cf9f64d3ca24e45b18e4d7433d5dc29abbf4f96df1f72609ecR81
Comment out https://github.com/cursorless-dev/cursorless/pull/1637/files#diff-ad70c9f7733ed465149fcdfe7b4b2a300c71938633e4896dc05f90d92c992fe3R2 (and in other talon file)
Comment out https://github.com/cursorless-dev/cursorless/pull/1637/files#diff-ad70c9f7733ed465149fcdfe7b4b2a300c71938633e4896dc05f90d92c992fe3R1 (and in other talon file)

pokey self-assigned this

Member Author

pokey commented Jan 25, 2024

Update: removing this single line cuts DFA by half!

cursorless/cursorless-talon/src/cursorless.talon

Line 2 in aa95401

mode: user.cursorless_spoken_form_test

pokey added this to the Short list milestone

pokey mentioned this issue

Inactive modes causing slow DFA compilation talonvoice/talon#650

Closed

Member

AndreasArvidsson commented Feb 10, 2024

@pokey can we close this one?

Member

AndreasArvidsson commented Jan 24, 2025

Compilation time looks fine for me

AndreasArvidsson closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment