Skip to content

Add tests for writing spoken forms json from Talon #1977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tracked by #1974
pokey opened this issue Oct 27, 2023 · 0 comments
Open
Tracked by #1974

Add tests for writing spoken forms json from Talon #1977

pokey opened this issue Oct 27, 2023 · 0 comments
Labels
code quality Improvements to code quality talon Related to cursorless-talon
Milestone

Comments

@pokey
Copy link
Member

pokey commented Oct 27, 2023

The functionality introduced in #1939 has no tests. We'd like to add tests by using the test context to set csv overrides dir setting to tmp dir, then override spokenforms json output location, then call the update function. Check output, then tweak csv, then check output again

We could also possibly use this mechanism instead of normalized_ctx, because spoken forms will be default when we do this. We'd want to remove all - prefixes on spoken forms to enable the ones that are off by default. But testing changes is prob a good idea anyway, as suggested above

@pokey pokey added this to the Short list milestone Oct 27, 2023
@pokey pokey added code quality Improvements to code quality talon Related to cursorless-talon labels Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improvements to code quality talon Related to cursorless-talon
Projects
None yet
Development

No branches or pull requests

1 participant