Skip to content

Write spokenForms.json from Talon #1939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 30, 2023
Merged

Write spokenForms.json from Talon #1939

merged 12 commits into from
Oct 30, 2023

Conversation

pokey
Copy link
Member

@pokey pokey commented Oct 12, 2023 •
edited
Loading

Checklist

  • [-] I have added tests (will do in follow-up)
  • [-] I have updated the docs and cheatsheet
  • I have not broken the cheatsheet
  • have the json have its own version number

@pokey pokey mentioned this pull request Oct 12, 2023
Merged
pokey
pokey commented Oct 12, 2023
View reviewed changes
@pokey pokey force-pushed the pokey/write-spokenformsjson-from-talon branch from 2410b74 to 0c3eca4 Compare October 12, 2023 17:41
@pokey pokey force-pushed the base/pokey/write-spokenformsjson-from-talon branch from e23f358 to ef19b8a Compare October 12, 2023 17:41
@pokey pokey force-pushed the pokey/write-spokenformsjson-from-talon branch from 0c3eca4 to 91b22f2 Compare October 16, 2023 15:02
@pokey pokey force-pushed the base/pokey/write-spokenformsjson-from-talon branch 2 times, most recently from 6771a2e to bd48c91 Compare October 16, 2023 15:29
@pokey pokey force-pushed the pokey/write-spokenformsjson-from-talon branch from 91b22f2 to b45b136 Compare October 16, 2023 15:29
@pokey pokey force-pushed the base/pokey/write-spokenformsjson-from-talon branch from bd48c91 to fed01ce Compare October 16, 2023 15:47
@pokey pokey force-pushed the pokey/write-spokenformsjson-from-talon branch from b45b136 to a39fb93 Compare October 16, 2023 15:47
@pokey pokey force-pushed the base/pokey/write-spokenformsjson-from-talon branch from fed01ce to 3a5c453 Compare October 16, 2023 16:17
@pokey pokey force-pushed the pokey/write-spokenformsjson-from-talon branch 2 times, most recently from 1522908 to aaeb7a8 Compare October 17, 2023 13:55
@pokey pokey force-pushed the base/pokey/write-spokenformsjson-from-talon branch from 3ac95cf to d63c853 Compare October 17, 2023 14:11
@pokey pokey force-pushed the pokey/write-spokenformsjson-from-talon branch from aaeb7a8 to 74240bc Compare October 17, 2023 14:11
@pokey pokey force-pushed the base/pokey/write-spokenformsjson-from-talon branch from d63c853 to d2688db Compare October 18, 2023 15:06
@pokey pokey force-pushed the pokey/write-spokenformsjson-from-talon branch from 74240bc to 129b71e Compare October 18, 2023 15:06
@pokey pokey force-pushed the base/pokey/write-spokenformsjson-from-talon branch from d2688db to a3f8747 Compare October 18, 2023 15:08
@pokey pokey force-pushed the pokey/write-spokenformsjson-from-talon branch from 129b71e to 474772a Compare October 18, 2023 15:08
@pokey pokey force-pushed the base/pokey/write-spokenformsjson-from-talon branch from a3f8747 to 258ce7d Compare October 18, 2023 15:17
@pokey pokey force-pushed the pokey/write-spokenformsjson-from-talon branch from 474772a to 0542218 Compare October 18, 2023 15:17
@pokey pokey force-pushed the base/pokey/write-spokenformsjson-from-talon branch from 258ce7d to d80f28e Compare October 18, 2023 15:57
@pokey pokey force-pushed the pokey/write-spokenformsjson-from-talon branch from 0542218 to 3b87860 Compare October 18, 2023 15:57
@pokey pokey marked this pull request as ready for review October 18, 2023 17:43
@auscompgeek auscompgeek added the talon Related to cursorless-talon label Oct 19, 2023
@pokey pokey force-pushed the pokey/write-spokenformsjson-from-talon branch from 3b87860 to 3d8e394 Compare October 20, 2023 12:45
@pokey pokey changed the base branch from base/pokey/write-spokenformsjson-from-talon to pokey/allow-spoken-forms-generator-to-use-custom October 20, 2023 12:45
@pokey pokey force-pushed the pokey/write-spokenformsjson-from-talon branch from 3d8e394 to 3bfd6aa Compare October 20, 2023 12:51
@pokey pokey changed the base branch from pokey/allow-spoken-forms-generator-to-use-custom to main October 20, 2023 12:51
@pokey
Copy link
Member Author

pokey commented Oct 25, 2023 •
edited
Loading

ok @AndreasArvidsson this one is ready for review

@pokey pokey force-pushed the pokey/write-spokenformsjson-from-talon branch from 0713149 to e021c77 Compare October 26, 2023 16:29
@pokey
Copy link
Member Author

pokey commented Oct 26, 2023

this one is good to go now as well

This was referenced Oct 27, 2023
Open
Open
Closed
@pokey pokey added this pull request to the merge queue Oct 30, 2023
Merged via the queue into main with commit a75e017 Oct 30, 2023
@pokey pokey deleted the pokey/write-spokenformsjson-from-talon branch October 30, 2023 14:28
github-merge-queue bot pushed a commit that referenced this pull request Oct 30, 2023
@pokey
Get custom spoken forms from Talon (#1940)
cc155ba 
- This PR is the VSCode side of
#1939

## Checklist

- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
(tests added in #1941)
- [-] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [-] I have not broken the cheatsheet
cursorless-bot pushed a commit that referenced this pull request Oct 30, 2023
@pokey
Write spokenForms.json from Talon (#1939)
974b4a2 
- This PR is the Talon side of #1940

## Checklist

- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
(will do in follow-up)
- [-] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet
- [x] have the json have its own version number
fidgetingbits pushed a commit to fidgetingbits/cursorless that referenced this pull request Nov 3, 2023
@pokey
Write spokenForms.json from Talon (cursorless-dev#1939)
685483c 
- This PR is the Talon side of cursorless-dev#1940

## Checklist

- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
(will do in follow-up)
- [-] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet
- [x] have the json have its own version number
fidgetingbits pushed a commit to fidgetingbits/cursorless that referenced this pull request Nov 3, 2023
@pokey
Get custom spoken forms from Talon (cursorless-dev#1940)
0bb547a 
- This PR is the VSCode side of
cursorless-dev#1939

## Checklist

- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
(tests added in cursorless-dev#1941)
- [-] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [-] I have not broken the cheatsheet
thetomcraig-aya pushed a commit to thetomcraig/cursorless that referenced this pull request Mar 27, 2024
@pokey @cursorless-bot
Write spokenForms.json from Talon (cursorless-dev#1939)
b6345cc 
- This PR is the Talon side of cursorless-dev#1940

## Checklist

- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
(will do in follow-up)
- [-] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet
- [x] have the json have its own version number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasArvidsson AndreasArvidsson AndreasArvidsson approved these changes

Assignees
No one assigned
Labels
talon Related to cursorless-talon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pokey @AndreasArvidsson @auscompgeek