Get custom spoken forms from Talon #1940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
force-pushed
the
pokey/write-spokenformsjson-from-talon
branch
from
2410b74 to
0c3eca4
Compare
pokey
force-pushed
the
pokey/get-custom-spoken-forms-from-talon
branch
from
9286669 to
dad00fb
Compare
pokey
force-pushed
the
pokey/write-spokenformsjson-from-talon
branch
from
0c3eca4 to
91b22f2
Compare
pokey
force-pushed
the
pokey/get-custom-spoken-forms-from-talon
branch
from
c4e7b75 to
6a6d06a
Compare
pokey
force-pushed
the
pokey/write-spokenformsjson-from-talon
branch
from
91b22f2 to
b45b136
Compare
pokey
force-pushed
the
pokey/get-custom-spoken-forms-from-talon
branch
from
88af8bf to
5aefc8b
Compare
pokey
force-pushed
the
pokey/write-spokenformsjson-from-talon
branch
from
b45b136 to
a39fb93
Compare
pokey
force-pushed
the
pokey/get-custom-spoken-forms-from-talon
branch
2 times, most recently
from
88d7ec1 to
84d2f1d
Compare
pokey
force-pushed
the
pokey/write-spokenformsjson-from-talon
branch
from
1522908 to
aaeb7a8
Compare
pokey
force-pushed
the
pokey/get-custom-spoken-forms-from-talon
branch
2 times, most recently
from
60a927f to
c07368a
Compare
pokey
force-pushed
the
pokey/write-spokenformsjson-from-talon
branch
2 times, most recently
from
74240bc to
129b71e
Compare
pokey
force-pushed
the
pokey/get-custom-spoken-forms-from-talon
branch
2 times, most recently
from
2e509b7 to
983ebe2
Compare
pokey
force-pushed
the
pokey/write-spokenformsjson-from-talon
branch
from
129b71e to
474772a
Compare
pokey
force-pushed
the
pokey/get-custom-spoken-forms-from-talon
branch
from
983ebe2 to
516045d
Compare
pokey
force-pushed
the
pokey/write-spokenformsjson-from-talon
branch
from
474772a to
0542218
Compare
3 tasks
pokey
force-pushed
the
pokey/get-custom-spoken-forms-from-talon
branch
from
516045d to
e71eb95
Compare
pokey
force-pushed
the
pokey/write-spokenformsjson-from-talon
branch
from
3b87860 to
3d8e394
Compare
pokey
force-pushed
the
pokey/get-custom-spoken-forms-from-talon
branch
from
e71eb95 to
3abd5af
Compare
pokey
changed the base branch from
pokey/write-spokenformsjson-from-talon
to
base/pokey/get-custom-spoken-forms-from-talon
2 tasks
pokey
force-pushed
the
base/pokey/get-custom-spoken-forms-from-talon
branch
from
3d8e394 to
97cc750
Compare
pokey
force-pushed
the
pokey/get-custom-spoken-forms-from-talon
branch
from
3abd5af to
896bbe4
Compare
pokey
force-pushed
the
base/pokey/get-custom-spoken-forms-from-talon
branch
from
97cc750 to
f3920b5
Compare
pokey
force-pushed
the
pokey/get-custom-spoken-forms-from-talon
branch
from
896bbe4 to
c9f226b
Compare
pokey
commented
Oct 26, 2023
packages/cursorless-engine/src/nodeCommon/TalonSpokenFormsJsonReader.ts
Outdated
Show resolved
Hide resolved
|
ok @AndreasArvidsson all feedback addressed; this one is ready for review again. I managed to get down to 2 type assertions, and they're more reasonable ones. Factoring it out into a function and using a for loop did simplify things 👍 |
AndreasArvidsson
approved these changes
Oct 28, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
- This PR is the Talon side of #1940 ## Checklist - [-] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) (will do in follow-up) - [-] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] I have not broken the cheatsheet - [x] have the json have its own version number
cursorless-bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
- This PR is the Talon side of #1940 ## Checklist - [-] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) (will do in follow-up) - [-] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] I have not broken the cheatsheet - [x] have the json have its own version number
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
- Depends on #1940 ## Checklist - [x] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [-] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [-] I have not broken the cheatsheet
fidgetingbits
pushed a commit
to fidgetingbits/cursorless
that referenced
this pull request
Nov 3, 2023
This PR generalizes our spoken form generator to be able to handle custom spoken forms. Note that this PR doesn't contain the machinery to read custom spoken forms from talon; that happens in cursorless-dev#1940. This PR just prepares the api surface of the spoken form generator to handle those custom spoken forms ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
fidgetingbits
pushed a commit
to fidgetingbits/cursorless
that referenced
this pull request
Nov 3, 2023
- This PR is the Talon side of cursorless-dev#1940 ## Checklist - [-] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) (will do in follow-up) - [-] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] I have not broken the cheatsheet - [x] have the json have its own version number
fidgetingbits
pushed a commit
to fidgetingbits/cursorless
that referenced
this pull request
Nov 3, 2023
- This PR is the VSCode side of cursorless-dev#1939 ## Checklist - [-] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) (tests added in cursorless-dev#1941) - [-] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [-] I have not broken the cheatsheet
fidgetingbits
pushed a commit
to fidgetingbits/cursorless
that referenced
this pull request
Nov 3, 2023
- Depends on cursorless-dev#1940 ## Checklist - [x] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [-] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [-] I have not broken the cheatsheet
thetomcraig-aya
pushed a commit
to thetomcraig/cursorless
that referenced
this pull request
Mar 27, 2024
- This PR is the Talon side of cursorless-dev#1940 ## Checklist - [-] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) (will do in follow-up) - [-] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] I have not broken the cheatsheet - [x] have the json have its own version number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist