Allow spoken forms generator to use custom #1947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
force-pushed
the
pokey/allow-spoken-forms-generator-to-use-custom
branch
5 times, most recently
from
638ed06 to
f9f9f40
Compare
pokey
commented
Oct 18, 2023
There was a problem hiding this comment.
hmm this diff is pretty hard to read. you may want to try viewing it in the VSCode PR differ which you get with the GitHub pull requests extension
There was a problem hiding this comment.
it's okay to read with whitespace changes hidden
pokey
commented
Oct 18, 2023
packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/inference/takeHarpAndStringEach.yml
Show resolved
Hide resolved
pokey
commented
Oct 19, 2023
pokey
commented
Oct 19, 2023
pokey
commented
Oct 19, 2023
pokey
commented
Oct 19, 2023
packages/cursorless-engine/src/generateSpokenForm/getSpokenFormComponentMap.ts
Show resolved
Hide resolved
pokey
commented
Oct 19, 2023
pokey
force-pushed
the
pokey/allow-spoken-forms-generator-to-use-custom
branch
7 times, most recently
from
6fd8122 to
6ef26ed
Compare
pokey
force-pushed
the
pokey/allow-spoken-forms-generator-to-use-custom
branch
from
17c2839 to
95df930
Compare
pokey
force-pushed
the
pokey/allow-spoken-forms-generator-to-use-custom
branch
from
b862590 to
46b82dc
Compare
|
ok @AndreasArvidsson this PR is ready for review. As @auscompgeek suggests, I'd recommend using the GitHub setting at the top to disable showing whitespace diffs; makes the spoken form generator diff much more readable 
|
AndreasArvidsson
approved these changes
Oct 21, 2023
pokey
force-pushed
the
pokey/allow-spoken-forms-generator-to-use-custom
branch
from
fb283e8 to
fd64a8f
Compare
fidgetingbits
pushed a commit
to fidgetingbits/cursorless
that referenced
this pull request
Nov 3, 2023
This PR generalizes our spoken form generator to be able to handle custom spoken forms. Note that this PR doesn't contain the machinery to read custom spoken forms from talon; that happens in cursorless-dev#1940. This PR just prepares the api surface of the spoken form generator to handle those custom spoken forms ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generalizes our spoken form generator to be able to handle custom spoken forms. Note that this PR doesn't contain the machinery to read custom spoken forms from talon; that happens in #1940. This PR just prepares the api surface of the spoken form generator to handle those custom spoken forms
Checklist