-
-
Notifications
You must be signed in to change notification settings - Fork 91
Scope info provider #1941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Scope info provider #1941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9fe1a3 to
3b17e39
Compare
c4e7b75 to
6a6d06a
Compare
887c7df to
82a8ef5
Compare
6cc1055 to
6be3705
Compare
074ddf4 to
33ce2a2
Compare
88d7ec1 to
84d2f1d
Compare
ceaf377 to
1c6435b
Compare
dfba742 to
36bcc86
Compare
7b220c3 to
0c5e9b3
Compare
60a927f to
c07368a
Compare
3c5d883 to
962f921
Compare
07562d7 to
2e509b7
Compare
d80a73f to
9f61dd8
Compare
2e509b7 to
983ebe2
Compare
9f61dd8 to
709fb57
Compare
983ebe2 to
516045d
Compare
709fb57 to
d995f40
Compare
516045d to
e71eb95
Compare
d995f40 to
a977bf0
Compare
3abd5af to
896bbe4
Compare
a977bf0 to
49c3931
Compare
896bbe4 to
c9f226b
Compare
2f3d43e to
156ff94
Compare
bdcc34e to
0979cba
Compare
beadd68 to
156ff94
Compare
|
Ok @AndreasArvidsson this one is ready too; let's wait to merge because it depends on #1940 |
61e18e0 to
cb22980
Compare
0f5bd0d to
8df8047
Compare
17f1bb0 to
67149ce
Compare
8df8047 to
223fc7e
Compare
pokey
commented
Oct 26, 2023
223fc7e to
67f8ce3
Compare
AndreasArvidsson
approved these changes
Oct 28, 2023
67149ce to
0c9a833
Compare
67f8ce3 to
5820193
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
- This PR is the VSCode side of #1939 ## Checklist - [-] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) (tests added in #1941) - [-] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [-] I have not broken the cheatsheet
5820193 to
26b5d39
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
- Depends on #1941 - Depends on #1946 ## Checklist - [-] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) (see comment below) - [x] Add descriptions to section headings (eg present, not present, etc) - [x] File issue about using lang icons for lang-specific scopes - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] I have not broken the cheatsheet - [x] File issue for showing scopes touching, as well as equal to, selection - [x] Checkboxes from original #1663
cursorless-bot
pushed a commit
to cursorless-dev/cursorless-talon
that referenced
this pull request
Oct 30, 2023
- Depends on cursorless-dev/cursorless#1941 - Depends on #1946 ## Checklist - [-] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) (see comment below) - [x] Add descriptions to section headings (eg present, not present, etc) - [x] File issue about using lang icons for lang-specific scopes - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] I have not broken the cheatsheet - [x] File issue for showing scopes touching, as well as equal to, selection - [x] Checkboxes from original #1663
cursorless-bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
- Depends on #1941 - Depends on #1946 ## Checklist - [-] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) (see comment below) - [x] Add descriptions to section headings (eg present, not present, etc) - [x] File issue about using lang icons for lang-specific scopes - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] I have not broken the cheatsheet - [x] File issue for showing scopes touching, as well as equal to, selection - [x] Checkboxes from original #1663
fidgetingbits
pushed a commit
to fidgetingbits/cursorless
that referenced
this pull request
Nov 3, 2023
- This PR is the VSCode side of cursorless-dev#1939 ## Checklist - [-] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) (tests added in cursorless-dev#1941) - [-] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [-] I have not broken the cheatsheet
fidgetingbits
pushed a commit
to fidgetingbits/cursorless
that referenced
this pull request
Nov 3, 2023
- Depends on cursorless-dev#1940 ## Checklist - [x] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [-] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [-] I have not broken the cheatsheet
fidgetingbits
pushed a commit
to fidgetingbits/cursorless
that referenced
this pull request
Nov 3, 2023
- Depends on cursorless-dev#1941 - Depends on cursorless-dev#1946 ## Checklist - [-] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) (see comment below) - [x] Add descriptions to section headings (eg present, not present, etc) - [x] File issue about using lang icons for lang-specific scopes - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] I have not broken the cheatsheet - [x] File issue for showing scopes touching, as well as equal to, selection - [x] Checkboxes from original cursorless-dev#1663
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist