Revisit cloneWith function

[pokey]

Defined in BaseTarget.

cursorless/src/processTargets/targets/BaseTarget.ts

Lines 116 to 123 in 8639b56

	readonly cloneWith = (parameters: CloneWithParameters) => {
	const constructor = Object.getPrototypeOf(this).constructor;
	return new constructor({
	...this.getCloneParameters(),
	...parameters,
	});
	};

It uses any, so programmer can forget clone parameters without Typescript detecting it. Possible solutions:

• Enable explicit-function-return-type to force programmer to strongly type their clone parameters
• Move implementation to derived types, maybe with a utility function that they can use?
• Figure out a way to make it strongly typed in the base class?

[AndreasArvidsson]

Since clone parameters now is typed can we close this one or do we still want to the other suggestions?

cursorless/packages/cursorless-engine/src/processTargets/targets/BaseTarget.ts

Line 136 in 0e4c9d9

protected abstract getCloneParameters(): TParameters;

[pokey]

ah right, I think this one was fixed by #1534. @auscompgeek do you agree?