Skip to content

"Chuck" should work with position when it is part of a range #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #1616
pokey opened this issue Jun 6, 2022 · 7 comments · Fixed by #1668
Closed
Tracked by #1616

"Chuck" should work with position when it is part of a range #741

pokey opened this issue Jun 6, 2022 · 7 comments · Fixed by #1668
Assignees
Labels
bug Something isn't working

Comments

@pokey
Copy link
Member

pokey commented Jun 6, 2022

In the following code:

/**
 * Add the file path ending of a recorded test and ONLY that one will run
 * when using the "Run Single Extension Test" launch configuration.
 */

/**
 * The grep string to pass to Mocha when running a subset of tests. This grep
 * string will be used with the "Run Single Extension Test" launch
 * configuration.
 */
export const testSubsetGrepString = "actions/postVest.yml";

With my cursor at the end of the file I wanted to say "chuck start of block past start of file". However this showed me the error message 'Please use "leading" modifier; removal is not supported for "before"'. This could of course be accomplished using a range anchor exclusion, but I don't see any reason why we shouldn't support this command. The problem is likely that when we combine a two positions to form a range it also becomes a position. This is likely not the correct behavior; it should probably become a plain target or a weak target.

@pokey pokey added the bug Something isn't working label Jun 6, 2022
@AndreasArvidsson AndreasArvidsson self-assigned this Jul 5, 2023
@AndreasArvidsson
Copy link
Member

AndreasArvidsson commented Jul 7, 2023

This will just fix itself once start of and end of are not positions anymore
#803

@AndreasArvidsson
Copy link
Member

Fixed

@pokey
Copy link
Member Author

pokey commented Jul 15, 2023

Nice! Do we have a test?

@AndreasArvidsson
Copy link
Member

Probably not, but that entire warning logic is removed. There is nothing special about the chuck action or ranges. Start of an end of is now a modifier like all the others.
We could of course easily add a test or two.

@pokey
Copy link
Member Author

pokey commented Jul 15, 2023

Huh yeah you're right. That's kinda cool. Prob still worth adding a test tho, if nothing else so we exercise constructing a range target from empty anchor / active. Should be a 30-second endeavour for whomever records it anyway

@pokey pokey reopened this Jul 15, 2023
@pokey
Copy link
Member Author

pokey commented Jul 15, 2023

Oh I see I forgot that "chuck" was part of the picture here. Presumably we have "start of past end of" tests. I agree this problem has kind of just become irrelevant now

@pokey pokey closed this as completed Jul 15, 2023
@pokey
Copy link
Member Author

pokey commented Jul 15, 2023

But I guess maybe worth testing the removal semantics of whatever kind of target comes out when you construct a range between "start of" / "end of" targets

Man I really keep waffling here 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants