-
-
Notifications
You must be signed in to change notification settings - Fork 84
Filter modifiers #1008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter modifiers #1008
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super cool to see that this was actually as trivial as we hoped. Great sign. Left a couple minor comments
Ok I have an alternative idea: how about we just create a meta-modifier called "only" that can accept any scope. It tries to expand to the scope. If it fails, it returns It also might be useful to have a forgiving version of containing scope. Could be a flag on either usual containing scope or on this modifier. As mentioned above it can be accomplished by chaining: "funk only funks", so maybe not that important 🤷♂️ Should be trivial to impl, tho will be better with plurals and proper scope handlers But I'm hesitant to introduce the stuff here if we'll replace it with this more powerful version |
It is an interesting idea. Maybe we should do that in addition to the ones we have here? In some sense I think that content fits my mental image better than |
I'm just hesitant to add something to the csv if we aren't sure about it |
I think we should add those in addition and keep the three added here. |
Let's chat tomorrow |
@pokey Updated. I'm still a bit hesitant if we should add the word "keep" before the default spoken form? This is really only a modifier for multiple cursors so maybe it's fine to be a bit verbose? |
* Every line returns empty lines * Added new filter modifiers * Updated line tests * Added filter tests * updated spoken forms * Update filter stage names * File rename * Refactored
* Every line returns empty lines * Added new filter modifiers * Updated line tests * Added filter tests * updated spoken forms * Update filter stage names * File rename * Refactored
Fixes #1005
Fixes #1006
Checklist
"every line"
should include empty and whitespace lines