Added "its" modifier to use with inference
#1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
reviewed
Oct 10, 2022
|
I'm fine with your changes, but I'm starting to lean towards just not doing documentation and leave that up to you ;) |
haha I do tend to do a bit of tweaking. super helpful to have the rough draft tho. tbh I don't think I changed that much; just moved it to a different section and did a bit of word-smithing |
|
@pokey Warning message added. Ready for another review. |
pokey
force-pushed
the
its_modifier
branch
4 times, most recently
from
c88373d to
5945f6d
Compare
pokey
changed the base branch from
main
to
pokey/add-support-for-spying-ide-add-idemessages
pokey
reviewed
Oct 13, 2022
Comment on lines
+24
to
+26
| ide: | ||
| messages: | ||
| - {type: warning, id: deprecatedPositionInference} |
There was a problem hiding this comment.
Note that we capture the warning message here
pokey
force-pushed
the
pokey/add-support-for-spying-ide-add-idemessages
branch
from
7433d71 to
29d5849
Compare
Base automatically changed from
pokey/add-support-for-spying-ide-add-idemessages
to
main
October 14, 2022 10:48
pokey
previously approved these changes
Oct 14, 2022
pokey
reviewed
Oct 14, 2022
| @@ -1,25 +0,0 @@ | |||
| import { Listener } from "../../util/Notifier"; | |||
There was a problem hiding this comment.
I removed this file because we're not actually spying it anyway; no need to write spies for everything if we're not spying them
pokey
changed the title
"its" modifier to use with inference
cursorless-bot
pushed a commit
that referenced
this pull request
Oct 14, 2022
* Added its modifier to use with inference * Fix test failures * Remove unnecessary spy Co-authored-by: Pokey Rule <[email protected]>
thetomcraig-aya
pushed a commit
to thetomcraig/cursorless
that referenced
this pull request
Mar 27, 2024
* Added its modifier to use with inference * Fix test failures * Remove unnecessary spy Co-authored-by: Pokey Rule <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"take air past end of its line"Fixes #736
Fixes #571
Depends on #1033
Checklist