Add extension side of "subject" scope type
#1148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 18, 2022
pokey
force-pushed
the
pokey/add-subject-scope-type
branch
from
091b73c to
252ca38
Compare
pokey
force-pushed
the
pokey/add-subject-scope-type
branch
from
252ca38 to
bbc1ca4
Compare
pokey
force-pushed
the
pokey/add-subject-scope-type
branch
from
4fdee59 to
d887aae
Compare
|
Is this scope type actually needed? Couldn't you just use a hat? |
|
As discussed in meet-up:
|
pokey
changed the title
"subject" scope type"subject" scope type
AndreasArvidsson
approved these changes
Dec 15, 2022
pokey
added a commit
that referenced
this pull request
Dec 21, 2022
- Partially addresses #1172 - Waiting to add Talon side until we're more confident in this scope type - Split from #831 ## Checklist - [x] Add Typescript - [x] Add C - [x] Add C# - [x] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] I have not broken the cheatsheet Co-authored-by: Michael Doronin <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Andreas Arvidsson <[email protected]>
2 tasks
What if the subject was a complex expression? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"subject"scope type #1172Checklist
Co-authored-by: Michael Doronin [email protected]