Clean up makeGraph.makeGetter #1167
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auscompgeek
reviewed
Dec 10, 2022
Comment on lines
+15
to
+17
| const componentValue = components[key]; | ||
| if (componentValue != null) { | ||
| return componentValue; |
There was a problem hiding this comment.
If TypeScript is updated we should be able to still check components[key] without an intermediate const: https://devblogs.microsoft.com/typescript/announcing-typescript-4-7/#control-flow-analysis-for-element-access
Suggested change
| const componentValue = components[key]; | |
| if (componentValue != null) { | |
| return componentValue; | |
| if (components[key] != null) { | |
| return components[key]; |
There was a problem hiding this comment.
Nice. Fwiw I'll prob just close this PR tho. I factored it out of another PR, but we're moving to pure DI, so this code is all going to go away
|
Closing, as we're moving to pure DI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist