Fix modal keyboard interface broken by #1094 #1213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
force-pushed
the
pokey/fix-modal-keyboard-interface-broken-by-1094
branch
from
4cc71da to
e984d36
Compare
auscompgeek
approved these changes
Jan 6, 2023
|
For posterity, this is fixing the empty selection being expanded to the current token instead of starting modal keyboard mode, when the cursor is on a token. (Starting modal keyboard mode on an empty line still works before this fix.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using the equivalent of "take this" to set the target to be the current selection when you enter cursorless keyboard mode, but that obviously broke when we made "take this" refer to token. This PR effectively changes the command we use to
"highlight just this"Checklist