Conversation
| command: | ||
| version: 1 | ||
| spokenForm: bring air to after bat slice past fine | ||
| spokenForm: bring air after bat slice fine |
There was a problem hiding this comment.
In the generation we had to choose "slice" vs "slice past" for the default spoken form
There was a problem hiding this comment.
as long as we have some tests for "slice past"
| languageId: plaintext | ||
| command: | ||
| spokenForm: change one lines | ||
| spokenForm: change line forward |
There was a problem hiding this comment.
There's no way to disambiguate "one lines" vs "line forward". I think for the singular using line forward is more intuitive.
There was a problem hiding this comment.
Agreed. Maybe worth having spoken form test for this one as well. Is it supposed to be plural?
...s/cursorless-vscode-e2e/src/suite/fixtures/recorded/subtoken/takeFirstPastSecondWordHarp.yml
Show resolved
Hide resolved
pokey
left a comment
pokey
left a comment
There was a problem hiding this comment.
Looks good to me as long as we add spoken form tests for the couple comments below
| command: | ||
| version: 1 | ||
| spokenForm: bring air to after bat slice past fine | ||
| spokenForm: bring air after bat slice fine |
There was a problem hiding this comment.
as long as we have some tests for "slice past"
| languageId: plaintext | ||
| command: | ||
| spokenForm: change one lines | ||
| spokenForm: change line forward |
There was a problem hiding this comment.
Agreed. Maybe worth having spoken form test for this one as well. Is it supposed to be plural?
2 participants
Checklist