replace treesitter #start-position with .startof

[josharian]

This particular query pattern is going to be very common.
It's worth having syntactic sugar for.
In particular, this reduces the level of indentation
required to express that a node's associated scope
(iteration, trailing, leading, etc.)
should start or end at the start or end of a different node.

While we're here, make a related error message more helpful.

Checklist

• I have added tests
• [/] I have updated the docs and cheatsheet
• [/] I have not broken the cheatsheet

[josharian]

The code of the end of the test is 😬 . Looking forward to knowing the right way to do it. And anything else. :) Be brutal.

[josharian]

I guess alternative approach would be to make the rewrite a method on MutableQueryCapture, and in line the forEach loop that calls it. Then the test would mostly go away. :)

[pokey]

mostly looks fine, with some minor comments. still slightly on the fence here but seems you and @AndreasArvidsson are leaning towards it so I'll defer because I don't feel too strongly. I do wonder if we want to use startPosition rather than startOf. But again I'll defer to you and @AndreasArvidsson as I don't feel too strongly bout that either

[AndreasArvidsson]

I think this is an improvement. I agree with all pokeys comments.

[pokey]

But @AndreasArvidsson you're leaning towards startOf over startPosition?

[AndreasArvidsson]

But @AndreasArvidsson you're leaning towards startOf over startPosition?

Yes I think so

[josharian]

thanks! Please take another look.

[pokey]

Left one tweak to make jsdoc clearer, but otherwise looks good!