Conversation
pokey
approved these changes
Aug 2, 2023
Member
pokey
left a comment
pokey
left a comment
There was a problem hiding this comment.
Looks good. Made a couple tweaks; merge if happy
We should revisit the way we talk about scopes in the docs at some point, because the language describing these examples is very much rooted in the old world where scopes and containing scope modifiers are one and the same. Probably a visualization would be the easiest, but we can wait until "short paint" has been upgraded to next-gen scope handler
Collaborator
Author
|
Looks good to me. I don't have to do anything to officially accept your changes, right? |
Member
|
nope! |
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
Fixes cheatsheet bug introduced in #1698 which only updated spoken form in defaults.json, which is used by cursorless.org/cheatsheet, but didn't update the code path that is used when user says "cursorless cheatsheet" ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
cursorless-bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
Fixes cheatsheet bug introduced in #1698 which only updated spoken form in defaults.json, which is used by cursorless.org/cheatsheet, but didn't update the code path that is used when user says "cursorless cheatsheet" ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
fidgetingbits
pushed a commit
to fidgetingbits/cursorless
that referenced
this pull request
Nov 3, 2023
Fixes cheatsheet bug introduced in cursorless-dev#1698 which only updated spoken form in defaults.json, which is used by cursorless.org/cheatsheet, but didn't update the code path that is used when user says "cursorless cheatsheet" ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
thetomcraig-aya
pushed a commit
to thetomcraig/cursorless
that referenced
this pull request
Mar 27, 2024
Fixes cheatsheet bug introduced in cursorless-dev#1698 which only updated spoken form in defaults.json, which is used by cursorless.org/cheatsheet, but didn't update the code path that is used when user says "cursorless cheatsheet" ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a section about "short paint" in main reference page. Improved explanation in cheatsheet.
Checklist