Skip to content

tsconfig: Enable isolatedModules #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2023
Merged

tsconfig: Enable isolatedModules #1829

merged 2 commits into from
Sep 1, 2023

Conversation

auscompgeek
Copy link
Member

@auscompgeek auscompgeek commented Aug 24, 2023

esbuild recommends enabling this to avoid miscompilation.

Checklist

esbuild recommends enabling this to avoid miscompilation.
https://esbuild.github.io/content-types/#isolated-modules
@auscompgeek auscompgeek marked this pull request as ready for review August 24, 2023 12:27
@auscompgeek auscompgeek requested a review from pokey as a code owner August 24, 2023 12:27
@auscompgeek

This comment was marked as outdated.

@auscompgeek auscompgeek force-pushed the auscompgeek/isolated-modules branch from 48de213 to 1ed8fcd Compare August 25, 2023 15:39
@auscompgeek
Copy link
Member Author

I just realised I misread the isolatedModules docs. I've reordered the commits and will open a separate PR for the type import lint rule 😅

Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find 👍. Left a minor comment / question

@pokey pokey added this pull request to the merge queue Sep 1, 2023
Merged via the queue into main with commit 48cedd8 Sep 1, 2023
@pokey pokey deleted the auscompgeek/isolated-modules branch September 1, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants