cull trimRange #1898
Merged
cull trimRange #1898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is unused. I believe that it also contains a latent bug, when the range contains entirely whitespace. Noticed during discussion at #1854 (comment)
|
Ping. |
1 similar comment
|
Ping. |
|
Why not. Since we can always re-add it if we need it later. |
AndreasArvidsson
approved these changes
Nov 1, 2023
|
Thanks @AndreasArvidsson. I recall looking at this PR, following the link to the original PR discussion that spawned it, getting stuck there, and that's the last thing I remember 😅. So I appreciate you taking action here 😄 |
fidgetingbits
pushed a commit
to fidgetingbits/cursorless
that referenced
this pull request
Nov 3, 2023
It is unused. I believe that it also contains a latent bug, when the range contains entirely whitespace. Noticed during discussion at cursorless-dev#1854 (comment) ## Checklist - [-] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [-] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [-] I have not broken the cheatsheet --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is unused. I believe that it also contains a latent bug,
when the range contains entirely whitespace.
Noticed during discussion at
#1854 (comment)
Checklist