Skip to content

Added argument to call action#1900

Merged
AndreasArvidsson merged 11 commits intomainfrom
callWithArgument
Sep 28, 2023
Merged

Added argument to call action#1900
AndreasArvidsson merged 11 commits intomainfrom
callWithArgument

Conversation

@AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Sep 16, 2023 •
edited
Loading

call air on bat

Checklist

@AndreasArvidsson AndreasArvidsson mentioned this pull request Sep 16, 2023
Open
@AndreasArvidsson AndreasArvidsson marked this pull request as ready for review September 16, 2023 11:11
@AndreasArvidsson
Copy link
Member Author

AndreasArvidsson commented Sep 16, 2023

I've solved this without adding a new data class by both having it in <user.cursorless_action_or_ide_command> for the single target case and then adding a new command to cursorless.talon for the two target case. I think we should think of migrate bring, swap, move and so on to this format and getting rid of the data classes. This also have the benefit of actually utilizing user.cursorless_command() from our public api in the single target case which makes it so that we're always testing that path as well.

@pokey
Copy link
Member

pokey commented Sep 16, 2023

How's DFA?

@AndreasArvidsson
Copy link
Member Author

AndreasArvidsson commented Sep 16, 2023

How's DFA?

Just restarted Talon which to vscode and issued a Cursorless command
IO [audio]=2100.000ms [compile]=86.483ms [emit]=31.591ms [decode]=1.151ms [total]=119.226ms

@pokey
Copy link
Member

pokey commented Sep 16, 2023

nice 🙌. presumably that is not much slower than main?

@AndreasArvidsson
Copy link
Member Author

AndreasArvidsson commented Sep 16, 2023

No looks to be within error marginal. I don't think I could even get a reliable figure if I don't rerun them more times than I have patience for.

auscompgeek
auscompgeek reviewed Sep 16, 2023
View reviewed changes
pokey
pokey approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made small fixes to cheatsheet, otherwise looks good! Merge if you're happy with my fixes

@AndreasArvidsson AndreasArvidsson added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit c2fb509 Sep 28, 2023
@AndreasArvidsson AndreasArvidsson deleted the callWithArgument branch September 28, 2023 14:53
cursorless-bot pushed a commit that referenced this pull request Sep 28, 2023
@AndreasArvidsson @pre-commit-ci-lite
@auscompgeek @pokey
Added argument to call action (#1900)
fcca9ae 
`call air on bat`

## Checklist

- [x] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: David Vo <auscompgeek@users.noreply.github.com>
Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
fidgetingbits pushed a commit to fidgetingbits/cursorless that referenced this pull request Nov 3, 2023
@AndreasArvidsson @pre-commit-ci-lite
@auscompgeek @pokey
Added argument to call action (cursorless-dev#1900)
1f48fda 
`call air on bat`

## Checklist

- [x] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: David Vo <auscompgeek@users.noreply.github.com>
Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
thetomcraig-aya pushed a commit to thetomcraig/cursorless that referenced this pull request Mar 27, 2024
@AndreasArvidsson @pre-commit-ci-lite
@auscompgeek @pokey @cursorless-bot
Added argument to call action (cursorless-dev#1900)
bd52296 
`call air on bat`

## Checklist

- [x] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: David Vo <auscompgeek@users.noreply.github.com>
Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@auscompgeek auscompgeek auscompgeek left review comments

@pokey pokey pokey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AndreasArvidsson @pokey @auscompgeek