Merged
Conversation
Member
|
Need to wait on #1854 to merge so we can trim the end of this range: 
|
pokey
approved these changes
Nov 30, 2023
Member
pokey
left a comment
pokey
left a comment
There was a problem hiding this comment.
This looks great! Made minor tweak. The one thing it's missing is "pour item" for a - -separated list. I think we need to wait for the ability to grab insertion delimiter from real node for that though, (ie the thing we'll use for arg delimiter), because we need the correct indentation
Member
|
feel free to merge if you're happy with my changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist