Skip to content

Added yaml support #2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 30, 2023
Merged

Added yaml support #2071

merged 7 commits into from
Nov 30, 2023

Conversation

AndreasArvidsson
Copy link
Member

Checklist

  • I have added tests
  • [-] I have updated the docs and cheatsheet
  • [-] I have not broken the cheatsheet

@pokey
Copy link
Member

pokey commented Nov 30, 2023

Need to wait on #1854 to merge so we can trim the end of this range:

image

Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Made minor tweak. The one thing it's missing is "pour item" for a - -separated list. I think we need to wait for the ability to grab insertion delimiter from real node for that though, (ie the thing we'll use for arg delimiter), because we need the correct indentation

@pokey
Copy link
Member

pokey commented Nov 30, 2023

feel free to merge if you're happy with my changes

@AndreasArvidsson AndreasArvidsson added this pull request to the merge queue Nov 30, 2023
Merged via the queue into main with commit bc9cf96 Nov 30, 2023
@AndreasArvidsson AndreasArvidsson deleted the yaml branch November 30, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants