-
-
Notifications
You must be signed in to change notification settings - Fork 88
Cursorless tutorial ced #2131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cursorless tutorial ced #2131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few quick comments. Nice start!
packages/cursorless-vscode/src/keyboard/grammar/generated/grammar.ts
Outdated
Show resolved
Hide resolved
we have 2 commands (getContent and setupStep) respectively to get the full content of the tutorial and to ask the extension to set up the state in vscode for the current step. we already support parsing the spoken form for the command to be said by the user during the getContent command and spawning the contents in vscode for the setupStep. We need to parse the other spoken forms and to initialize better the vscode content with the hats, etc.
@pokey I've pushed some very nice changes that make things being parsed from the extension side. Not everything is implemented but I would be curious if the general idea is fine with you. |
An initial version of the tutorial is live. |
this PR seems to have pulled in some extraneous commits, so it's really hard to review 😅. If you're not sure how to clean it up, lmk and I can help you |
It is because you had to merge the main branch to fix some issues iirc. You should be able to diff against that commit from the main branch maybe? |
## Checklist - [-] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [-] I have not broken the cheatsheet
## Checklist - [-] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [-] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [-] I have not broken the cheatsheet
## Checklist - [-] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [-] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [-] I have not broken the cheatsheet
…v#2250) Related discussion: https://talonvoice.slack.com/archives/C026KPTJE6T/p1708813018817909 ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [X] I have not broken the cheatsheet
## Checklist - [-] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [-] I have not broken the cheatsheet
Initial work towards #492; will be used to parse scope types in #2131 Exposes a function `parseScopeType` that can parse strings like `funk`, `curly` etc into their corresponding scope type payloads Here's a railroad: https://deploy-preview-2295--cursorless.netlify.app/custom-command-railroad ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
closing in favour of the original #360, as it's easier to use a branch that's part of the main repo |
Currently requires https://github.com/saidelike/talon_hud/tree/cursorless fork of the talon HUD
Checklist
tutorial.py