Skip to content

Cursorless tutorial ced #2131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

saidelike
Copy link
Collaborator

@saidelike saidelike commented Dec 13, 2023

Currently requires https://github.com/saidelike/talon_hud/tree/cursorless fork of the talon HUD

Checklist

  • Fix scope tree view
  • Fix broken references to css eg reset
  • Merge HUD changes
  • Properly support custom actions and other necessary custom spoken forms
  • Properly support custom symbol spoken forms (eg alphabet)
  • Figure out how to properly detect VSCode focused
  • Tune tutorial content? Maybe better for follow-up PR
  • Highlight marks that need to be targeted, so user doesn't have to search for them
  • Remove print statements and commented out code from tutorial.py
  • Figure out how to only run step preparation when you have the right window focused. Some of the time @pokey gets error message after "cursorles help" step
    image
  • Open new window on start?
  • Ensure you're in the right window / editor before restoring state, so we don't accidentally clobber something
  • I have added tests
  • I have updated the docs and cheatsheet
  • I have not broken the cheatsheet

Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few quick comments. Nice start!

Cedric Halbronn and others added 6 commits December 19, 2023 15:44
we have 2 commands (getContent and setupStep) respectively to get the full content of the tutorial and to ask the extension to set up the state in vscode for the current step.

we already support parsing the spoken form for the command to be said by the user during the getContent command and spawning the contents in vscode for the setupStep.

We need to parse the other spoken forms and to initialize better the vscode content with the hats, etc.
@saidelike
Copy link
Collaborator Author

@pokey I've pushed some very nice changes that make things being parsed from the extension side. Not everything is implemented but I would be curious if the general idea is fine with you.

@saidelike
Copy link
Collaborator Author

An initial version of the tutorial is live.
Please use https://github.com/saidelike/talon_hud/tree/cursorless fork/branch for the HUD

@pokey
Copy link
Member

pokey commented Jan 10, 2024

this PR seems to have pulled in some extraneous commits, so it's really hard to review 😅. If you're not sure how to clean it up, lmk and I can help you

@saidelike
Copy link
Collaborator Author

this PR seems to have pulled in some extraneous commits, so it's really hard to review 😅. If you're not sure how to clean it up, lmk and I can help you

It is because you had to merge the main branch to fix some issues iirc. You should be able to diff against that commit from the main branch maybe?

@pokey pokey changed the base branch from cursorless-tutorial to main January 11, 2024 11:30
pokey and others added 26 commits February 28, 2024 11:57
github-merge-queue bot pushed a commit that referenced this pull request Apr 22, 2024
Initial work towards
#492; will be used to
parse scope types in
#2131

Exposes a function `parseScopeType` that can parse strings like `funk`,
`curly` etc into their corresponding scope type payloads

Here's a railroad:
https://deploy-preview-2295--cursorless.netlify.app/custom-command-railroad

## Checklist

- [ ] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [ ] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [ ] I have not broken the cheatsheet
@pokey
Copy link
Member

pokey commented Apr 22, 2024

closing in favour of the original #360, as it's easier to use a branch that's part of the main repo

@pokey pokey closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants